bug#37648: [PATCH] Add "next" and "previous" shortcuts in eww-history buffers

bug#37648: [PATCH] Add "next" and "previous" shortcuts in eww-history buffers

[Raimon Grau]

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

Hello,

I found that eww-history-mode buffers (you get there via 
eww-list-histories or 'H' in an *eww* buffer) has plain 'n' and 
'p' shortcuts commented out since some refactor it had and haven't 
been added.

Here's a patch to enable them.

Cheers,

Raimon Grau,


[-- Attachment #2: 0001-Add-next-and-previous-shortcuts-in-eww-history-buffe.patch --]
[-- Type: text/plain, Size: 947 bytes --]

From 23136c029ec9bbb0c5ccb78dfba275d41d94d225 Mon Sep 17 00:00:00 2001
From: Raimon Grau <raimonster@gmail.com>
Date: Mon, 7 Oct 2019 13:42:24 +0100
Subject: [PATCH] Add "next" and "previous" shortcuts in eww-history buffers

* lisp/net/eww.el (eww-history-mode-map): add "n" and "p" for
  "next-line" and "previous-line".
---
 lisp/net/eww.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index fb495a9..d9539f7 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1901,8 +1901,8 @@ eww-history-browse
 (defvar eww-history-mode-map
   (let ((map (make-sparse-keymap)))
     (define-key map "\r" 'eww-history-browse)
-;;    (define-key map "n" 'next-error-no-select)
-;;    (define-key map "p" 'previous-error-no-select)
+    (define-key map "n" 'next-line)
+    (define-key map "p" 'previous-line)
 
     (easy-menu-define nil map
       "Menu for `eww-history-mode-map'."
-- 
2.7.4

bug#37648: [PATCH] Add "next" and "previous" shortcuts in eww-history buffers

[Lars Ingebrigtsen]

Raimon Grau <raimon@konghq.com> writes:

> I found that eww-history-mode buffers (you get there via
> eww-list-histories or 'H' in an *eww* buffer) has plain 'n' and 
> 'p' shortcuts commented out since some refactor it had and haven't
> been added.
>
> Here's a patch to enable them.

Thanks; applied to the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no