From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Raimon Grau Newsgroups: gmane.emacs.bugs Subject: bug#37648: [PATCH] Add "next" and "previous" shortcuts in eww-history buffers Date: Mon, 07 Oct 2019 20:33:00 +0100 Message-ID: <871rvos64z.fsf@konghq.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="12475"; mail-complaints-to="usenet@blaine.gmane.org" To: 37648@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 07 21:34:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iHYln-00037c-6k for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Oct 2019 21:34:11 +0200 Original-Received: from localhost ([::1]:49244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHYll-0005y0-Eb for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Oct 2019 15:34:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59430) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHYlf-0005xt-Hh for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2019 15:34:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHYle-0001Pq-HB for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2019 15:34:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40360) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iHYle-0001Ph-DS for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2019 15:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iHYle-0005B4-8i for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2019 15:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Raimon Grau Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Oct 2019 19:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 37648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.157047679019834 (code B ref -1); Mon, 07 Oct 2019 19:34:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Oct 2019 19:33:10 +0000 Original-Received: from localhost ([127.0.0.1]:49181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHYko-00059o-9h for submit@debbugs.gnu.org; Mon, 07 Oct 2019 15:33:10 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:41378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHYkm-00059f-3P for submit@debbugs.gnu.org; Mon, 07 Oct 2019 15:33:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59273) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHYkk-0005rG-Ud for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2019 15:33:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHYkj-00006t-Pt for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2019 15:33:06 -0400 Original-Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:44906) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iHYkj-00005x-HL for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2019 15:33:05 -0400 Original-Received: by mail-wr1-x431.google.com with SMTP id z9so16627592wrl.11 for ; Mon, 07 Oct 2019 12:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konghq.com; s=google; h=from:to:subject:date:message-id:mime-version; bh=Ec/YjrHjoMHPOFizKrNJCdfVRzBC9Dh3smRzTGMDuDU=; b=YY4h0d6IIxV8oC8Cct4bfQAJKbz6p5Y1mmG4mNyIdj/eXQz9ijvHAa3H0vRkE6LS79 NS1HkgFah9ayLO+J+iz2fcO04ETC+s+gATHklQ4VRmO/pT7BBebXX18r+5IjCYlxQd4C 8sW2spXHj3E5IrlW3Ut+/1GsMyvk47dBOLEIw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=Ec/YjrHjoMHPOFizKrNJCdfVRzBC9Dh3smRzTGMDuDU=; b=jtO8zpgKK7WNb/RnHXT1ECACKMtyjTE5fVSKACPbeB5DWf+3YnTC3bYZLmVMwp9K7a Ry9r4+AR3pX4Rg/OAlREq2CSMFT4VSq6gt9tythyTd6Le8BbNvcZgS0V71+13XVK9Riu p4wh4oUFHiXoGSgKT/VwwR9ZpBnTsmij2gfHPUA7MXlx3P+sYEAxpt1A5xK51J06Kthi JOWiGHG049eWmgDzzVjvs2xPcCajgDnRMKdQtYmgYQMS1LKQ+oKaHAeffM92G+M7YGvr Crw7VXdOASYmH5sU5ogVA+UZAVZN0TslYoKf93mOQxQ6kq+iG4AyeGzmIIetqDnq2GQo xSUA== X-Gm-Message-State: APjAAAUJjDBC2MrrFAg2MKyXJHY3AVdtLKGMB3otMS9V0De57FBlFLoE 2JvJ7datgEVrgB1p2PdibRCUvJ2+gHU= X-Google-Smtp-Source: APXvYqyOUsoCYIUnpSVP4r6/nCjAOGLgs2n1Bfu5aZqGr0PhuHcs4h4tXEp7McxpZ3TjrFTtYHPWrg== X-Received: by 2002:a5d:670c:: with SMTP id o12mr12508688wru.103.1570476782689; Mon, 07 Oct 2019 12:33:02 -0700 (PDT) Original-Received: from raikong (85.155.103.148.dyn.user.ono.com. [85.155.103.148]) by smtp.gmail.com with ESMTPSA id j26sm24714508wrd.2.2019.10.07.12.33.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Oct 2019 12:33:01 -0700 (PDT) X-Google-Original-From: Raimon Grau X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168585 Archived-At: --=-=-= Content-Type: text/plain; format=flowed Hello, I found that eww-history-mode buffers (you get there via eww-list-histories or 'H' in an *eww* buffer) has plain 'n' and 'p' shortcuts commented out since some refactor it had and haven't been added. Here's a patch to enable them. Cheers, Raimon Grau, --=-=-= Content-Type: text/plain Content-Disposition: inline; filename=0001-Add-next-and-previous-shortcuts-in-eww-history-buffe.patch >From 23136c029ec9bbb0c5ccb78dfba275d41d94d225 Mon Sep 17 00:00:00 2001 From: Raimon Grau Date: Mon, 7 Oct 2019 13:42:24 +0100 Subject: [PATCH] Add "next" and "previous" shortcuts in eww-history buffers * lisp/net/eww.el (eww-history-mode-map): add "n" and "p" for "next-line" and "previous-line". --- lisp/net/eww.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index fb495a9..d9539f7 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -1901,8 +1901,8 @@ eww-history-browse (defvar eww-history-mode-map (let ((map (make-sparse-keymap))) (define-key map "\r" 'eww-history-browse) -;; (define-key map "n" 'next-error-no-select) -;; (define-key map "p" 'previous-error-no-select) + (define-key map "n" 'next-line) + (define-key map "p" 'previous-line) (easy-menu-define nil map "Menu for `eww-history-mode-map'." -- 2.7.4 --=-=-=--