unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Raimon Grau <raimon@konghq.com>
To: 37648@debbugs.gnu.org
Subject: bug#37648: [PATCH] Add "next" and "previous" shortcuts in eww-history buffers
Date: Mon, 07 Oct 2019 20:33:00 +0100	[thread overview]
Message-ID: <871rvos64z.fsf@konghq.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

Hello,

I found that eww-history-mode buffers (you get there via 
eww-list-histories or 'H' in an *eww* buffer) has plain 'n' and 
'p' shortcuts commented out since some refactor it had and haven't 
been added.

Here's a patch to enable them.

Cheers,

Raimon Grau,


[-- Attachment #2: 0001-Add-next-and-previous-shortcuts-in-eww-history-buffe.patch --]
[-- Type: text/plain, Size: 947 bytes --]

From 23136c029ec9bbb0c5ccb78dfba275d41d94d225 Mon Sep 17 00:00:00 2001
From: Raimon Grau <raimonster@gmail.com>
Date: Mon, 7 Oct 2019 13:42:24 +0100
Subject: [PATCH] Add "next" and "previous" shortcuts in eww-history buffers

* lisp/net/eww.el (eww-history-mode-map): add "n" and "p" for
  "next-line" and "previous-line".
---
 lisp/net/eww.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index fb495a9..d9539f7 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1901,8 +1901,8 @@ eww-history-browse
 (defvar eww-history-mode-map
   (let ((map (make-sparse-keymap)))
     (define-key map "\r" 'eww-history-browse)
-;;    (define-key map "n" 'next-error-no-select)
-;;    (define-key map "p" 'previous-error-no-select)
+    (define-key map "n" 'next-line)
+    (define-key map "p" 'previous-line)
 
     (easy-menu-define nil map
       "Menu for `eww-history-mode-map'."
-- 
2.7.4


             reply	other threads:[~2019-10-07 19:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 19:33 Raimon Grau [this message]
2019-10-13  2:27 ` bug#37648: [PATCH] Add "next" and "previous" shortcuts in eww-history buffers Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rvos64z.fsf@konghq.com \
    --to=raimon@konghq.com \
    --cc=37648@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).