From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66567: [PATCH] use-package: Add ignored-files support to :vc keyword Date: Fri, 03 May 2024 09:35:19 +0300 Message-ID: <868r0rjtco.fsf@gnu.org> References: <877cnn4z2v.fsf@hyperspace> <87ttq5u9fj.fsf@posteo.net> <87ttq5bx2y.fsf@hyperspace> <87r0l91vww.fsf@posteo.net> <87r0l9fsl1.fsf@hyperspace> <871qd91l9e.fsf@posteo.net> <87bkc59wv8.fsf@hyperspace> <87wmutfe8l.fsf@posteo.net> <87pm0hvmwj.fsf@hyperspace> <87msve9mri.fsf@posteo.net> <874jbg11p6.fsf@hyperspace> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30837"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, 66567@debbugs.gnu.org To: Tony Zorman , John Wiegley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 03 08:37:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s2mXd-0007mJ-OT for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 May 2024 08:37:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2mXD-0004K4-Cf; Fri, 03 May 2024 02:36:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2mXB-0004Jh-9d for bug-gnu-emacs@gnu.org; Fri, 03 May 2024 02:36:41 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s2mXB-0001sb-0B for bug-gnu-emacs@gnu.org; Fri, 03 May 2024 02:36:41 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s2mXW-0002aj-H0 for bug-gnu-emacs@gnu.org; Fri, 03 May 2024 02:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 May 2024 06:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66567 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66567-submit@debbugs.gnu.org id=B66567.17147181979951 (code B ref 66567); Fri, 03 May 2024 06:37:02 +0000 Original-Received: (at 66567) by debbugs.gnu.org; 3 May 2024 06:36:37 +0000 Original-Received: from localhost ([127.0.0.1]:46177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2mX6-0002aR-Up for submit@debbugs.gnu.org; Fri, 03 May 2024 02:36:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2mX3-0002aL-Nu for 66567@debbugs.gnu.org; Fri, 03 May 2024 02:36:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2mWa-0001nK-2x; Fri, 03 May 2024 02:36:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=5qWGO4y4TD3C7jdQpfOTOki4TAqkc3g9R29Tms+wto8=; b=PyAFPkodj/7tyb+ck5Ei L6M4yO6DjNVLu+sP7gY2hCWOGONi1HBYqdmWARTv/Swjrr8lgOMi97yg6v/ZO2ygCf7kPy91Jv4vR EvuiZOyhBRiazgMlvGTwBPKHehi+9aMGIhfz/tjPDbxrG1xeXZ9EmnRMGZst6W8IQFQRs8wBmcbqC tjaaH9SiBgPGs/g6R/iBFl/TK0ZbFgxNJgufH2obE+ELYPt4WMh+gqn+6PQDFmY4jEj70Jmrm093Y upwZLWTS9H1OmTP37M/g09JwcKBGoqE2jjHQsgwLrub9DHlu4vv3Iv9mHYYWhJtFqD/x2jcnPJ/nr hoft/2nUDkuhiA==; In-Reply-To: <874jbg11p6.fsf@hyperspace> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284365 Archived-At: > Cc: 66567@debbugs.gnu.org > Date: Thu, 02 May 2024 20:57:41 +0200 > From: Tony Zorman via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > On Thu, Nov 16 2023 07:32, Philip Kaludercic wrote: > > Tony Zorman writes: > > > >> On Tue, Nov 07 2023 21:24, Philip Kaludercic wrote: > >>> Tony Zorman writes: > >>>> Now I'm a bit confused: where exactly? Inside of use-package or > >>>> package-vc? Either way, I think raising an error when the user inputs > >>>> nonsense is totally justified—I'd just like that error to be > >>>> understandable as quickly as possible. > >>> > >>> I was thinking that package-vc should emit an error, but that > >>> use-package could emit a warning, in case a new keyword is added to > >>> package-vc specifications but hasn't yet been added to the use-package > >>> layer -- mainly because I don't use the latter and am not that familiar > >>> with the code. > >> > >> On first thought this sounds good, but I think one would end up having > >> to sync the actual state of things in two places. What if package-vc.el > >> had a place where it stored all available commands? Then the use-package > >> integration could just use that. I think it would also be easier to have > >> this codified somewhere, rather than having to check the manual every > >> time. > > > > This sounds like a better solution, I can add a constant with all the > > symbols that you can then use. I am still a bit busy, so I cannot > > promise when I'll manage to do so, but I'll ping you when the changes > > have been pushed. > > Can I perhaps bump this myself instead? :) > > I'd really like to see this merged; if it helps move things along a > bit quicker, I can also make the necessary changes to package-vc.el. John, could you please review the patches and comment?