* bug#58948: 29.0.50; Add :noquery to 'make-network-process' used by eglot
@ 2022-11-01 17:45 Juri Linkov
2022-11-02 9:53 ` Robert Pluim
0 siblings, 1 reply; 3+ messages in thread
From: Juri Linkov @ 2022-11-01 17:45 UTC (permalink / raw)
To: 58948
[-- Attachment #1: Type: text/plain, Size: 284 bytes --]
Tags: patch
Every time while exiting Emacs, an internal process is displayed and
asked whether to exit.
Eglot already uses `:noquery t' in two places for `make-process',
but can't use the same for `open-network-stream' because it's still unhandled.
Here is the patch that adds it:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: make-network-process-noquery.patch --]
[-- Type: text/x-diff, Size: 1354 bytes --]
diff --git a/lisp/net/network-stream.el b/lisp/net/network-stream.el
index 38a5e14c946..c092fd5f012 100644
--- a/lisp/net/network-stream.el
+++ b/lisp/net/network-stream.el
@@ -195,6 +195,7 @@ open-network-stream
(make-network-process :name name :buffer buffer
:host (puny-encode-domain host) :service service
:nowait (plist-get parameters :nowait)
+ :noquery (plist-get parameters :noquery)
:tls-parameters
(plist-get parameters :tls-parameters)
:coding (plist-get parameters :coding))
diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index 0a0d73eb6d2..204121045a0 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -1200,7 +1200,8 @@ eglot--connect
(pcase-let ((`(,connection . ,inferior)
(eglot--inferior-bootstrap
readable-name
- contact)))
+ contact
+ '(:noquery t))))
(setq autostart-inferior-process inferior)
connection))))
((stringp (car contact))
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#58948: 29.0.50; Add :noquery to 'make-network-process' used by eglot
2022-11-01 17:45 bug#58948: 29.0.50; Add :noquery to 'make-network-process' used by eglot Juri Linkov
@ 2022-11-02 9:53 ` Robert Pluim
2022-11-02 18:22 ` Juri Linkov
0 siblings, 1 reply; 3+ messages in thread
From: Robert Pluim @ 2022-11-02 9:53 UTC (permalink / raw)
To: Juri Linkov; +Cc: 58948
>>>>> On Tue, 01 Nov 2022 19:45:42 +0200, Juri Linkov <juri@linkov.net> said:
Juri> Tags: patch
Juri> Every time while exiting Emacs, an internal process is displayed and
Juri> asked whether to exit.
Juri> Eglot already uses `:noquery t' in two places for `make-process',
Juri> but can't use the same for `open-network-stream' because it's still unhandled.
Juri> Here is the patch that adds it:
I guess this is ok, although itʼs missing documentation and a commit
message :-)
Iʼm even tempted to say that unrecognized keyword arguments should
just be passed on to `make-network-process' as-is, but thatʼs a bigger
and riskier change.
Robert
--
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#58948: 29.0.50; Add :noquery to 'make-network-process' used by eglot
2022-11-02 9:53 ` Robert Pluim
@ 2022-11-02 18:22 ` Juri Linkov
0 siblings, 0 replies; 3+ messages in thread
From: Juri Linkov @ 2022-11-02 18:22 UTC (permalink / raw)
To: Robert Pluim; +Cc: 58948
close 58948 29.0.50
thanks
> Juri> Tags: patch
> Juri> Every time while exiting Emacs, an internal process is displayed and
> Juri> asked whether to exit.
>
> Juri> Eglot already uses `:noquery t' in two places for `make-process',
> Juri> but can't use the same for `open-network-stream' because it's still unhandled.
> Juri> Here is the patch that adds it:
>
> I guess this is ok, although itʼs missing documentation and a commit
> message :-)
Thanks for reviewing, now pushed with doc changes.
> Iʼm even tempted to say that unrecognized keyword arguments should
> just be passed on to `make-network-process' as-is, but thatʼs a bigger
> and riskier change.
Agreed. Maybe then more parameters of make-network-process
could be copied to open-network-stream manually one by one.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-02 18:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-01 17:45 bug#58948: 29.0.50; Add :noquery to 'make-network-process' used by eglot Juri Linkov
2022-11-02 9:53 ` Robert Pluim
2022-11-02 18:22 ` Juri Linkov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).