From: Juri Linkov <juri@linkov.net>
To: Robert Pluim <rpluim@gmail.com>
Cc: 58948@debbugs.gnu.org
Subject: bug#58948: 29.0.50; Add :noquery to 'make-network-process' used by eglot
Date: Wed, 02 Nov 2022 20:22:52 +0200 [thread overview]
Message-ID: <86r0ylxlkz.fsf@mail.linkov.net> (raw)
In-Reply-To: <87o7tpof69.fsf@gmail.com> (Robert Pluim's message of "Wed, 02 Nov 2022 10:53:50 +0100")
close 58948 29.0.50
thanks
> Juri> Tags: patch
> Juri> Every time while exiting Emacs, an internal process is displayed and
> Juri> asked whether to exit.
>
> Juri> Eglot already uses `:noquery t' in two places for `make-process',
> Juri> but can't use the same for `open-network-stream' because it's still unhandled.
> Juri> Here is the patch that adds it:
>
> I guess this is ok, although itʼs missing documentation and a commit
> message :-)
Thanks for reviewing, now pushed with doc changes.
> Iʼm even tempted to say that unrecognized keyword arguments should
> just be passed on to `make-network-process' as-is, but thatʼs a bigger
> and riskier change.
Agreed. Maybe then more parameters of make-network-process
could be copied to open-network-stream manually one by one.
prev parent reply other threads:[~2022-11-02 18:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 17:45 bug#58948: 29.0.50; Add :noquery to 'make-network-process' used by eglot Juri Linkov
2022-11-02 9:53 ` Robert Pluim
2022-11-02 18:22 ` Juri Linkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86r0ylxlkz.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=58948@debbugs.gnu.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).