From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#58948: 29.0.50; Add :noquery to 'make-network-process' used by eglot Date: Wed, 02 Nov 2022 20:22:52 +0200 Organization: LINKOV.NET Message-ID: <86r0ylxlkz.fsf@mail.linkov.net> References: <865yfyimox.fsf@mail.linkov.net> <87o7tpof69.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14337"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 58948@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 02 19:42:06 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqIgg-0003ci-AJ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Nov 2022 19:42:06 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqIfi-0004sY-7u; Wed, 02 Nov 2022 14:41:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqIff-0004pt-Jt for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 14:41:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oqIff-00045b-BC for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 14:41:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oqIR9-000682-PM for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 14:26:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2022 18:26:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58948 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58948-submit@debbugs.gnu.org id=B58948.166741350423397 (code B ref 58948); Wed, 02 Nov 2022 18:26:03 +0000 Original-Received: (at 58948) by debbugs.gnu.org; 2 Nov 2022 18:25:04 +0000 Original-Received: from localhost ([127.0.0.1]:47161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqIQB-00065H-Ii for submit@debbugs.gnu.org; Wed, 02 Nov 2022 14:25:04 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:55095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqIPu-00064P-SN; Wed, 02 Nov 2022 14:25:02 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id F17101BF204; Wed, 2 Nov 2022 18:24:37 +0000 (UTC) In-Reply-To: <87o7tpof69.fsf@gmail.com> (Robert Pluim's message of "Wed, 02 Nov 2022 10:53:50 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246886 Archived-At: close 58948 29.0.50 thanks > Juri> Tags: patch > Juri> Every time while exiting Emacs, an internal process is displayed and > Juri> asked whether to exit. > > Juri> Eglot already uses `:noquery t' in two places for `make-process', > Juri> but can't use the same for `open-network-stream' because it's still unhandled. > Juri> Here is the patch that adds it: > > I guess this is ok, although itʼs missing documentation and a commit > message :-) Thanks for reviewing, now pushed with doc changes. > Iʼm even tempted to say that unrecognized keyword arguments should > just be passed on to `make-network-process' as-is, but thatʼs a bigger > and riskier change. Agreed. Maybe then more parameters of make-network-process could be copied to open-network-stream manually one by one.