From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode Date: Tue, 24 Aug 2021 20:59:40 +0300 Message-ID: <83zgt6vi43.fsf@gnu.org> References: <838s0rvyfu.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14008"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50179@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 24 20:00:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mIaib-0003OV-11 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Aug 2021 20:00:13 +0200 Original-Received: from localhost ([::1]:47796 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mIaiY-0000Uo-Ua for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Aug 2021 14:00:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIaiR-0000UQ-HQ for bug-gnu-emacs@gnu.org; Tue, 24 Aug 2021 14:00:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33607) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mIaiR-0000wB-9j for bug-gnu-emacs@gnu.org; Tue, 24 Aug 2021 14:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mIaiR-0004JN-7x for bug-gnu-emacs@gnu.org; Tue, 24 Aug 2021 14:00:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Aug 2021 18:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50179-submit@debbugs.gnu.org id=B50179.162982799616524 (code B ref 50179); Tue, 24 Aug 2021 18:00:03 +0000 Original-Received: (at 50179) by debbugs.gnu.org; 24 Aug 2021 17:59:56 +0000 Original-Received: from localhost ([127.0.0.1]:45152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIaiK-0004IS-Cd for submit@debbugs.gnu.org; Tue, 24 Aug 2021 13:59:56 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIaiG-0004I1-Bf for 50179@debbugs.gnu.org; Tue, 24 Aug 2021 13:59:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45528) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mIaiB-0000iN-46; Tue, 24 Aug 2021 13:59:47 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1217 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIaiA-00063S-Mf; Tue, 24 Aug 2021 13:59:47 -0400 In-Reply-To: (message from Jim Porter on Tue, 24 Aug 2021 10:38:06 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212563 Archived-At: > From: Jim Porter > Date: Tue, 24 Aug 2021 10:38:06 -0700 > Cc: 50179@debbugs.gnu.org > > > I wouldn't offer a customizable list for this: users have no > > particular reason to redefine standard colors. > > I made this a defcustom because `ansi-color-faces-vector' and > `ansi-color-names-vector' are defcustoms too. More practically > speaking, I'd want to customize this new variable to make these colors > match the Emacs theme I use. I chose colors in this patch to > complement `ansi-color-names-vector', but they'd clash with my theme. How can named colors change with the theme? Faces can, but colors are absolute. Bright-yellow is the same color whatever the theme. At least IMO. I wonder if others think otherwise. > > > +(defcustom term-color-bold-is-bright nil > > > + "If set to non-nil, combining ANSI bold and a color produces the bright > > > +version of that color." > > > + :group 'term > > > + :type 'boolean > > > + :version "28.1") > > > > Do we really need 2 separate knobs for these two features? How > > probable is it that the same user will want to have bright colors in > > one package, but not in the other? > > I doubt anyone would want to control these independently. It'd be nice > to have a single defcustom for this, but I wasn't sure where it should > go in that case. If we agree to have a single defcustom, then where to put it is secondary. > Would it be ok to use `ansi-color-bold-is-bright' > (from patch 1 in `ansi-color.el') in `term.el'? Yes, why not? Thanks.