From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#47286: 28.0.50; [PATCH] Replace "(default %s)" with 'format-prompt' Date: Sun, 21 Mar 2021 08:07:44 +0200 Message-ID: <83y2ehavkf.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33690"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47286@debbugs.gnu.org To: Gabriel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 21 07:08:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNrG6-0008by-AS for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Mar 2021 07:08:18 +0100 Original-Received: from localhost ([::1]:44476 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNrG4-0007Vr-Tw for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Mar 2021 02:08:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNrFr-0007VQ-JZ for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2021 02:08:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41899) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lNrFq-0006jx-E4 for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2021 02:08:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lNrFq-0002mM-7N for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2021 02:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Mar 2021 06:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47286 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47286-submit@debbugs.gnu.org id=B47286.161630687210667 (code B ref 47286); Sun, 21 Mar 2021 06:08:02 +0000 Original-Received: (at 47286) by debbugs.gnu.org; 21 Mar 2021 06:07:52 +0000 Original-Received: from localhost ([127.0.0.1]:53445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNrFf-0002lz-Ux for submit@debbugs.gnu.org; Sun, 21 Mar 2021 02:07:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNrFe-0002ll-3l for 47286@debbugs.gnu.org; Sun, 21 Mar 2021 02:07:51 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35919) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNrFY-0006bO-H6; Sun, 21 Mar 2021 02:07:44 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3378 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lNrFX-0007Up-Hq; Sun, 21 Mar 2021 02:07:44 -0400 In-Reply-To: (message from Gabriel on Sat, 20 Mar 2021 19:22:52 -0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202756 Archived-At: > From: Gabriel > Date: Sat, 20 Mar 2021 19:22:52 -0300 > > This patches replaces several occurences of the hardcoded minibuffer > default prompt "(default %s)" with a call to 'format-prompt'. It also > removes the suffix ": ", when applicable, that is automatically handled > by 'format-prompt'. Thanks. A minor nit about formatting the commit log messages in such cases, where the same change is made in many places. > * lisp/cmuscheme.el (scheme-load-file, scheme-compile-file): Remove > prompt suffix ": ". > > * lisp/comint.el (comint-get-source): Use 'format-prompt'. > > * lisp/emulation/viper-cmd.el (viper-quote-region, viper-kill-buffer) > (viper-query-replace): Remove prompt suffix ": ". > (viper-read-string-with-history): Use 'format-prompt'. > > * lisp/eshell/esh-mode.el (eshell-find-tag): Remove prompt suffix ": ". > > * lisp/gnus/gnus-sum.el (gnus-articles-to-read) > (gnus-summary-search-article-forward) > (gnus-summary-search-article-backward): Use 'format-prompt'. Instead of having a long series of basically identical text, it is better to format this as follows: * lisp/cmuscheme.el (scheme-load-file, scheme-compile-file): * lisp/comint.el (comint-get-source): * lisp/emulation/viper-cmd.el (viper-quote-region, viper-kill-buffer) (viper-query-replace, viper-read-string-with-history): * lisp/eshell/esh-mode.el (eshell-find-tag): * lisp/gnus/gnus-sum.el (gnus-articles-to-read) (gnus-summary-search-article-forward) (gnus-summary-search-article-backward): * lisp/international/mule-cmds.el (set-input-method, toggle-input-method) (describe-input-method, set-language-environment) (describe-language-environment): * lisp/mh-e/mh-gnus.el (mh-mml-minibuffer-read-disposition) (mh-insert-letter) * lisp/mh-e/mh-mime.el (mh-display-with-external-viewer) (mh-mime-save-parts, mh-mh-forward-message) (mh-mml-query-cryptographic-method): Remove prompt suffix and use 'format-prompt'. That is, have the list of files and functions, and put the description of the change only in the last one. IME, this makes the long list easier to read and understand.