* bug#63867: 29.0.91; typescript-ts-mode does not highlight function signature overloads
@ 2023-06-03 9:37 Jimmy Yuen Ho Wong
2023-06-03 9:47 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Jimmy Yuen Ho Wong @ 2023-06-03 9:37 UTC (permalink / raw)
To: 63867
Reproduction:
1. C-x C-f test.ts
2. Insert:
```typescript
function fn():void;
function fn(arg1?:number, arg2?:string):void {
}
```
3. Observe the fn in the overload signature isn't highlighted as a
function name
Expectation:
Function signature overloads should highlight the function names.
^ permalink raw reply [flat|nested] 4+ messages in thread* bug#63867: 29.0.91; typescript-ts-mode does not highlight function signature overloads
2023-06-03 9:37 bug#63867: 29.0.91; typescript-ts-mode does not highlight function signature overloads Jimmy Yuen Ho Wong
@ 2023-06-03 9:47 ` Eli Zaretskii
2023-06-03 12:01 ` Dmitry Gutov
0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2023-06-03 9:47 UTC (permalink / raw)
To: Jimmy Yuen Ho Wong, Jostein Kjonigsen, Theodor Thornhill, Yuan Fu; +Cc: 63867
> From: Jimmy Yuen Ho Wong <wyuenho@gmail.com>
> Date: Sat, 03 Jun 2023 10:37:07 +0100
>
>
> Reproduction:
>
> 1. C-x C-f test.ts
> 2. Insert:
>
> ```typescript
> function fn():void;
> function fn(arg1?:number, arg2?:string):void {
> }
> ```
>
> 3. Observe the fn in the overload signature isn't highlighted as a
> function name
>
> Expectation:
>
> Function signature overloads should highlight the function names.
Thanks.
Guys, could you please look into fixing this?
^ permalink raw reply [flat|nested] 4+ messages in thread* bug#63867: 29.0.91; typescript-ts-mode does not highlight function signature overloads
2023-06-03 9:47 ` Eli Zaretskii
@ 2023-06-03 12:01 ` Dmitry Gutov
2023-06-03 12:20 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Gutov @ 2023-06-03 12:01 UTC (permalink / raw)
To: Eli Zaretskii, Jimmy Yuen Ho Wong, Jostein Kjonigsen,
Theodor Thornhill, Yuan Fu
Cc: 63867-done
On 03/06/2023 12:47, Eli Zaretskii wrote:
>> From: Jimmy Yuen Ho Wong<wyuenho@gmail.com>
>> Date: Sat, 03 Jun 2023 10:37:07 +0100
>>
>>
>> Reproduction:
>>
>> 1. C-x C-f test.ts
>> 2. Insert:
>>
>> ```typescript
>> function fn():void;
>> function fn(arg1?:number, arg2?:string):void {
>> }
>> ```
>>
>> 3. Observe the fn in the overload signature isn't highlighted as a
>> function name
>>
>> Expectation:
>>
>> Function signature overloads should highlight the function names.
> Thanks.
>
> Guys, could you please look into fixing this?
I've pushed a fix to emacs-29, rev 583ba1db7ee.
^ permalink raw reply [flat|nested] 4+ messages in thread* bug#63867: 29.0.91; typescript-ts-mode does not highlight function signature overloads
2023-06-03 12:01 ` Dmitry Gutov
@ 2023-06-03 12:20 ` Eli Zaretskii
0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2023-06-03 12:20 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: theo, casouri, jostein, wyuenho, 63867-done
> Date: Sat, 3 Jun 2023 15:01:28 +0300
> Cc: 63867-done@debbugs.gnu.org
> From: Dmitry Gutov <dmitry@gutov.dev>
>
> On 03/06/2023 12:47, Eli Zaretskii wrote:
> >> From: Jimmy Yuen Ho Wong<wyuenho@gmail.com>
> >> Date: Sat, 03 Jun 2023 10:37:07 +0100
> >>
> >>
> >> Reproduction:
> >>
> >> 1. C-x C-f test.ts
> >> 2. Insert:
> >>
> >> ```typescript
> >> function fn():void;
> >> function fn(arg1?:number, arg2?:string):void {
> >> }
> >> ```
> >>
> >> 3. Observe the fn in the overload signature isn't highlighted as a
> >> function name
> >>
> >> Expectation:
> >>
> >> Function signature overloads should highlight the function names.
> > Thanks.
> >
> > Guys, could you please look into fixing this?
>
> I've pushed a fix to emacs-29, rev 583ba1db7ee.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-03 12:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-03 9:37 bug#63867: 29.0.91; typescript-ts-mode does not highlight function signature overloads Jimmy Yuen Ho Wong
2023-06-03 9:47 ` Eli Zaretskii
2023-06-03 12:01 ` Dmitry Gutov
2023-06-03 12:20 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).