From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: theo@thornhill.no, casouri@gmail.com, jostein@kjonigsen.net,
wyuenho@gmail.com, 63867-done@debbugs.gnu.org
Subject: bug#63867: 29.0.91; typescript-ts-mode does not highlight function signature overloads
Date: Sat, 03 Jun 2023 15:20:13 +0300 [thread overview]
Message-ID: <83pm6c91qa.fsf@gnu.org> (raw)
In-Reply-To: <213224c6-5d92-f16c-b542-a827935917b3@gutov.dev> (message from Dmitry Gutov on Sat, 3 Jun 2023 15:01:28 +0300)
> Date: Sat, 3 Jun 2023 15:01:28 +0300
> Cc: 63867-done@debbugs.gnu.org
> From: Dmitry Gutov <dmitry@gutov.dev>
>
> On 03/06/2023 12:47, Eli Zaretskii wrote:
> >> From: Jimmy Yuen Ho Wong<wyuenho@gmail.com>
> >> Date: Sat, 03 Jun 2023 10:37:07 +0100
> >>
> >>
> >> Reproduction:
> >>
> >> 1. C-x C-f test.ts
> >> 2. Insert:
> >>
> >> ```typescript
> >> function fn():void;
> >> function fn(arg1?:number, arg2?:string):void {
> >> }
> >> ```
> >>
> >> 3. Observe the fn in the overload signature isn't highlighted as a
> >> function name
> >>
> >> Expectation:
> >>
> >> Function signature overloads should highlight the function names.
> > Thanks.
> >
> > Guys, could you please look into fixing this?
>
> I've pushed a fix to emacs-29, rev 583ba1db7ee.
Thanks.
prev parent reply other threads:[~2023-06-03 12:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-03 9:37 bug#63867: 29.0.91; typescript-ts-mode does not highlight function signature overloads Jimmy Yuen Ho Wong
2023-06-03 9:47 ` Eli Zaretskii
2023-06-03 12:01 ` Dmitry Gutov
2023-06-03 12:20 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83pm6c91qa.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=63867-done@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=dmitry@gutov.dev \
--cc=jostein@kjonigsen.net \
--cc=theo@thornhill.no \
--cc=wyuenho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).