From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63867: 29.0.91; typescript-ts-mode does not highlight function signature overloads Date: Sat, 03 Jun 2023 15:20:13 +0300 Message-ID: <83pm6c91qa.fsf@gnu.org> References: <83y1l098sy.fsf@gnu.org> <213224c6-5d92-f16c-b542-a827935917b3@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5968"; mail-complaints-to="usenet@ciao.gmane.io" Cc: theo@thornhill.no, casouri@gmail.com, jostein@kjonigsen.net, wyuenho@gmail.com, 63867-done@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 03 14:20:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q5QF4-0001MB-6Y for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Jun 2023 14:20:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q5QEn-0002BC-3y; Sat, 03 Jun 2023 08:20:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5QEk-0002An-Q5 for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2023 08:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q5QEk-0004gQ-GN for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2023 08:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q5QEj-0000Qt-Tp for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2023 08:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Jun 2023 12:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63867 X-GNU-PR-Package: emacs Original-Received: via spool by 63867-done@debbugs.gnu.org id=D63867.16857947801627 (code D ref 63867); Sat, 03 Jun 2023 12:20:01 +0000 Original-Received: (at 63867-done) by debbugs.gnu.org; 3 Jun 2023 12:19:40 +0000 Original-Received: from localhost ([127.0.0.1]:41759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5QEK-0000Q7-Jn for submit@debbugs.gnu.org; Sat, 03 Jun 2023 08:19:40 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5QEG-0000Ps-Ay for 63867-done@debbugs.gnu.org; Sat, 03 Jun 2023 08:19:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5QEA-0004d1-8r; Sat, 03 Jun 2023 08:19:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xCyEGmWQLzbwX7w0UTzjh8GgSn+Ly3DzBuh1izE03qQ=; b=eVbctH5mZqoX onDh9FiMA7BHaNF3SmvA1ljEGbsy+YJzbx3vT89BVCWgWa6+UDUAupC6UHolwt2fRlT2ePKEX84IG 4SVsI/p9D4Bx97xbIZTZq7azVdbmxuYGSwogp8sHNsE8Y7pbZ7QDg9s1Ah75xhhKyqJkvecz1otq4 vQ9Li5hgsMu8zK0lrjEsky6t+olVXISpGLVlDT0KF16/qT0s7KGpTQo3wCoa/AS7shjh8K2kQre4F F9ZckrXdNgispxJLzp0d6oFgnO3T6qtVwPAveQ8kxaDuE/fuSH5ECPnvVrrNkHXf/CFmeJfL9zrHB +1B+AB8OeV91UxEV7170sQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5QE8-00049k-6X; Sat, 03 Jun 2023 08:19:25 -0400 In-Reply-To: <213224c6-5d92-f16c-b542-a827935917b3@gutov.dev> (message from Dmitry Gutov on Sat, 3 Jun 2023 15:01:28 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262826 Archived-At: > Date: Sat, 3 Jun 2023 15:01:28 +0300 > Cc: 63867-done@debbugs.gnu.org > From: Dmitry Gutov > > On 03/06/2023 12:47, Eli Zaretskii wrote: > >> From: Jimmy Yuen Ho Wong > >> Date: Sat, 03 Jun 2023 10:37:07 +0100 > >> > >> > >> Reproduction: > >> > >> 1. C-x C-f test.ts > >> 2. Insert: > >> > >> ```typescript > >> function fn():void; > >> function fn(arg1?:number, arg2?:string):void { > >> } > >> ``` > >> > >> 3. Observe the fn in the overload signature isn't highlighted as a > >> function name > >> > >> Expectation: > >> > >> Function signature overloads should highlight the function names. > > Thanks. > > > > Guys, could you please look into fixing this? > > I've pushed a fix to emacs-29, rev 583ba1db7ee. Thanks.