unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 59622@debbugs.gnu.org
Subject: bug#59622: 29.0.50; [PATCH] Regression in Eshell's handling of escaped newlines
Date: Sun, 04 Dec 2022 09:26:04 +0200	[thread overview]
Message-ID: <83v8mrbpf7.fsf@gnu.org> (raw)
In-Reply-To: <c831e7a7-42ec-8dba-7b51-5d6e0b1fdced@gmail.com> (message from Jim Porter on Sat, 3 Dec 2022 17:41:50 -0800)

> Date: Sat, 3 Dec 2022 17:41:50 -0800
> From: Jim Porter <jporterbugs@gmail.com>
> 
> On 11/26/2022 4:36 PM, Jim Porter wrote:
> > Starting from "emacs -Q -f eshell":
> > 
> >    # Emacs 28
> >    ~ $ echo foo\
> >    bar
> > 
> >    foobar
> > 
> >    # Emacs 29
> >    ~ $ echo foo\
> >    bar
> > 
> >    foo
> >    bar
> > 
> > That is, Emacs 28 used to treat escaped newlines in the way you'd expect 
> > from other shells: it expands to the empty string. Now in Emacs 29, it 
> > inserts a literal newline.
> 
> Eli, since this is a regression from Emacs 28 (likely fallout from one 
> of my changes to fix some longstanding bugs with quotes in Eshell), 
> would my current patch be ok on the release branch?

Yes, but please do try to make it as safe as is feasible.

> I can try to minimize the changes a bit further (I slightly refactored
> 'eshell-parse-backslash' to reduce repetition), but since it has unit
> tests, I think it should be pretty safe either way.

OK.





  reply	other threads:[~2022-12-04  7:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-27  0:36 bug#59622: 29.0.50; [PATCH] Regression in Eshell's handling of escaped newlines Jim Porter
2022-11-27  0:42 ` Jim Porter
2022-12-04  1:41 ` Jim Porter
2022-12-04  7:26   ` Eli Zaretskii [this message]
2022-12-05  1:35     ` Jim Porter
2022-12-05 12:39       ` Eli Zaretskii
2022-12-07  4:18         ` Jim Porter
2022-12-07 13:34           ` Eli Zaretskii
2022-12-07 17:57             ` Jim Porter
2022-12-07 18:10               ` Eli Zaretskii
2022-12-08  5:47                 ` Jim Porter
2022-12-09  0:59                   ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83v8mrbpf7.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=59622@debbugs.gnu.org \
    --cc=jporterbugs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).