From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59622: 29.0.50; [PATCH] Regression in Eshell's handling of escaped newlines Date: Sun, 04 Dec 2022 09:26:04 +0200 Message-ID: <83v8mrbpf7.fsf@gnu.org> References: <90faf628-390d-1094-2fcb-e6a23ac46da8@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20442"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59622@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 04 08:27:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p1jP9-00059d-BR for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Dec 2022 08:27:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1jP2-0008TO-UM; Sun, 04 Dec 2022 02:27:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1jOz-0008QZ-Tf for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2022 02:27:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1jOw-0007U1-7j for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2022 02:27:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p1jOv-000851-OR for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2022 02:27:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Dec 2022 07:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59622 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59622-submit@debbugs.gnu.org id=B59622.167013879431050 (code B ref 59622); Sun, 04 Dec 2022 07:27:01 +0000 Original-Received: (at 59622) by debbugs.gnu.org; 4 Dec 2022 07:26:34 +0000 Original-Received: from localhost ([127.0.0.1]:55917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1jOT-00084k-TE for submit@debbugs.gnu.org; Sun, 04 Dec 2022 02:26:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1jOS-00084d-6p for 59622@debbugs.gnu.org; Sun, 04 Dec 2022 02:26:32 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1jOK-0007Qw-Ca; Sun, 04 Dec 2022 02:26:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=anir569Kvz6zpz8JP5GsC0iwZKPo701+JDfenkxkMRE=; b=f7UqLscd6sHE0JnyCX+4 X3nii719oaBn3SlwkuEOsM3Hcv64Q2F0h0niywiGc88UEKPe7cCxs2vv828jhRW23Tbf9VZsbD44T 5mm4zN4CEEUl4UFl26qeTONNsMZGwgiTGDAaAlAeLQMM41HMTUmWMG6PKoaeTvjRptayFUo8Hhzbp FQjB7xd7N3nqWyiE67vd759xfd56Y0vXL6n/1nN70iXbD7H6fhlvLpS2oF9ZQEvXv2Pa4LOwdpZO6 wM/H4jBkzNKj0QCafGH4IDw7nNckm3ym9jWMU4lD6c0cYxUWEULGUbVaJWV4KS1a+9EwSQIRrP4GF j0pX9w9q7rk99A==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1jOJ-0004i8-I9; Sun, 04 Dec 2022 02:26:23 -0500 In-Reply-To: (message from Jim Porter on Sat, 3 Dec 2022 17:41:50 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249902 Archived-At: > Date: Sat, 3 Dec 2022 17:41:50 -0800 > From: Jim Porter > > On 11/26/2022 4:36 PM, Jim Porter wrote: > > Starting from "emacs -Q -f eshell": > > > >   # Emacs 28 > >   ~ $ echo foo\ > >   bar > > > >   foobar > > > >   # Emacs 29 > >   ~ $ echo foo\ > >   bar > > > >   foo > >   bar > > > > That is, Emacs 28 used to treat escaped newlines in the way you'd expect > > from other shells: it expands to the empty string. Now in Emacs 29, it > > inserts a literal newline. > > Eli, since this is a regression from Emacs 28 (likely fallout from one > of my changes to fix some longstanding bugs with quotes in Eshell), > would my current patch be ok on the release branch? Yes, but please do try to make it as safe as is feasible. > I can try to minimize the changes a bit further (I slightly refactored > 'eshell-parse-backslash' to reduce repetition), but since it has unit > tests, I think it should be pretty safe either way. OK.