From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 59622@debbugs.gnu.org
Subject: bug#59622: 29.0.50; [PATCH] Regression in Eshell's handling of escaped newlines
Date: Mon, 05 Dec 2022 14:39:06 +0200 [thread overview]
Message-ID: <83359u9g9h.fsf@gnu.org> (raw)
In-Reply-To: <3d78b158-5fde-d4c0-0e9a-cb05e09bed6e@gmail.com> (message from Jim Porter on Sun, 4 Dec 2022 17:35:30 -0800)
> Date: Sun, 4 Dec 2022 17:35:30 -0800
> Cc: 59622@debbugs.gnu.org
> From: Jim Porter <jporterbugs@gmail.com>
>
> On 12/3/2022 11:26 PM, Eli Zaretskii wrote:
> >> Date: Sat, 3 Dec 2022 17:41:50 -0800
> >> From: Jim Porter <jporterbugs@gmail.com>
> >>
> >> Eli, since this is a regression from Emacs 28 (likely fallout from one
> >> of my changes to fix some longstanding bugs with quotes in Eshell),
> >> would my current patch be ok on the release branch?
> >
> > Yes, but please do try to make it as safe as is feasible.
>
> Thanks. How does this look? I just simplified the change in
> 'eshell-parse-backslash' so that the only difference is an extra
> conditional (plus whitespace changes).
Looks good, thanks. One comment:
> +When you escape a character with @code{\} outside of quotes, the
> +result is the literal character immediately following it, so
> +@samp{\$10} means the literal string @code{$10}. Inside of
> +double quotes, the result is the literal character following it if
> +that character is special, or the full @code{\@var{c}} sequence
> +otherwise; inside double-quotes, @code{\}, @code{"}, and @code{$} are
> +considered special.
The last sentence is very unclear, please try saying what you need in a
clearer way, and/or maybe add a couple of examples.
next prev parent reply other threads:[~2022-12-05 12:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-27 0:36 bug#59622: 29.0.50; [PATCH] Regression in Eshell's handling of escaped newlines Jim Porter
2022-11-27 0:42 ` Jim Porter
2022-12-04 1:41 ` Jim Porter
2022-12-04 7:26 ` Eli Zaretskii
2022-12-05 1:35 ` Jim Porter
2022-12-05 12:39 ` Eli Zaretskii [this message]
2022-12-07 4:18 ` Jim Porter
2022-12-07 13:34 ` Eli Zaretskii
2022-12-07 17:57 ` Jim Porter
2022-12-07 18:10 ` Eli Zaretskii
2022-12-08 5:47 ` Jim Porter
2022-12-09 0:59 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83359u9g9h.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=59622@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).