unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Jim Porter <jporterbugs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 59622@debbugs.gnu.org
Subject: bug#59622: 29.0.50; [PATCH] Regression in Eshell's handling of escaped newlines
Date: Wed, 7 Dec 2022 09:57:59 -0800	[thread overview]
Message-ID: <1335dd36-a50b-e03b-670b-58b1e08cc979@gmail.com> (raw)
In-Reply-To: <83v8mn49sj.fsf@gnu.org>

On 12/7/2022 5:34 AM, Eli Zaretskii wrote:
>> Date: Tue, 6 Dec 2022 20:18:30 -0800
>> Cc: 59622@debbugs.gnu.org
>> From: Jim Porter <jporterbugs@gmail.com>
>>
>> I also split the patch in two: the first patch for the 29 branch (which
>> makes the least code changes I could manage), and the second as an
>> additional small cleanup patch for master only.
> 
> Since which Emacs version do we have this regression?  If it's a very
> old regression, I'd prefer not to fix it on the emacs-29 branch.

This worked properly in Emacs 28 and is broken in 29. I'm not 100% sure 
which patch regressed it, but my guess is patch 0003 in bug#54227, which 
was merged in March.

>>   @subsection Quoting and escaping
>>   As with other shells, you can escape special characters and spaces
>> -with by prefixing the character with a backslash (@code{\}), or by
>> -surrounding the string with apostrophes (@code{''}) or double quotes
>> -(@code{""}).  This is needed especially for file names with special
>> -characters like pipe (@code{|}), which could be part of remote file
>> +with by prefixing the character with a backslash (@samp{\}), or by
> 
> "with by prefixing" is a typo; probably "with" should be dropped.

Good catch! I missed that despite reading it a few times while editing 
the manual.





  reply	other threads:[~2022-12-07 17:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-27  0:36 bug#59622: 29.0.50; [PATCH] Regression in Eshell's handling of escaped newlines Jim Porter
2022-11-27  0:42 ` Jim Porter
2022-12-04  1:41 ` Jim Porter
2022-12-04  7:26   ` Eli Zaretskii
2022-12-05  1:35     ` Jim Porter
2022-12-05 12:39       ` Eli Zaretskii
2022-12-07  4:18         ` Jim Porter
2022-12-07 13:34           ` Eli Zaretskii
2022-12-07 17:57             ` Jim Porter [this message]
2022-12-07 18:10               ` Eli Zaretskii
2022-12-08  5:47                 ` Jim Porter
2022-12-09  0:59                   ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1335dd36-a50b-e03b-670b-58b1e08cc979@gmail.com \
    --to=jporterbugs@gmail.com \
    --cc=59622@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).