From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace Date: Tue, 10 Aug 2021 16:38:29 +0300 Message-ID: <83r1f1fmi2.fsf@gnu.org> References: <87k0kudsb8.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32024"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49963@debbugs.gnu.org, monnier@iro.umontreal.ca, laslydone@protonmail.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 10 15:39:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mDRyJ-00088N-00 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 10 Aug 2021 15:39:11 +0200 Original-Received: from localhost ([::1]:34958 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDRyH-0005oj-IA for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 10 Aug 2021 09:39:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDRyA-0005nz-4y for bug-gnu-emacs@gnu.org; Tue, 10 Aug 2021 09:39:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47210) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mDRy9-0002Zx-U5 for bug-gnu-emacs@gnu.org; Tue, 10 Aug 2021 09:39:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mDRy9-0006kW-Rc for bug-gnu-emacs@gnu.org; Tue, 10 Aug 2021 09:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Aug 2021 13:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49963 X-GNU-PR-Package: emacs Original-Received: via spool by 49963-submit@debbugs.gnu.org id=B49963.162860271125899 (code B ref 49963); Tue, 10 Aug 2021 13:39:01 +0000 Original-Received: (at 49963) by debbugs.gnu.org; 10 Aug 2021 13:38:31 +0000 Original-Received: from localhost ([127.0.0.1]:58756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDRxf-0006jf-G0 for submit@debbugs.gnu.org; Tue, 10 Aug 2021 09:38:31 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDRxe-0006jP-2W for 49963@debbugs.gnu.org; Tue, 10 Aug 2021 09:38:30 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49304) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDRxV-0002IP-TV; Tue, 10 Aug 2021 09:38:23 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1187 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDRxU-00034E-60; Tue, 10 Aug 2021 09:38:21 -0400 In-Reply-To: <87k0kudsb8.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 10 Aug 2021 10:03:39 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211489 Archived-At: > From: Juri Linkov > Date: Tue, 10 Aug 2021 10:03:39 +0300 > Cc: 49963@debbugs.gnu.org, laslydone > > Stefan, please help. Wdired adds advice on a buffer-local isearch-filter-predicate, > and perform-replace adds advice on a let-bound isearch-filter-predicate > that changes the global value. This is the minimal test case: > > (add-function :after-while (local 'isearch-filter-predicate) > (lambda (&rest _) 'filter-local)) > > (let ((isearch-filter-predicate isearch-filter-predicate)) > (add-function :after-while isearch-filter-predicate > (lambda (&rest _) 'filter-letbound))) Regardless of how we solve this issue, could we please NOT use advices in such cases? is there really no other reasonable solution for this, like perhaps using some existing Isearch hook or (gasp!) introducing a new one? TIA