From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50179: [PATCH] Add support for "bright" ANSI colors to ansi-color and term-mode Date: Wed, 25 Aug 2021 14:57:30 +0300 Message-ID: <83lf4pvis5.fsf@gnu.org> References: <838s0rvyfu.fsf@gnu.org> <83zgt6vi43.fsf@gnu.org> <87r1eic8as.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36673"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, 50179@debbugs.gnu.org To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 25 14:09:27 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mIrih-0009KY-2x for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Aug 2021 14:09:27 +0200 Original-Received: from localhost ([::1]:50392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mIrig-0007P7-5U for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Aug 2021 08:09:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIrXf-0002no-Da for bug-gnu-emacs@gnu.org; Wed, 25 Aug 2021 07:58:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34436) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mIrXe-0003FH-7u for bug-gnu-emacs@gnu.org; Wed, 25 Aug 2021 07:58:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mIrXe-0005Rb-5E for bug-gnu-emacs@gnu.org; Wed, 25 Aug 2021 07:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Aug 2021 11:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50179-submit@debbugs.gnu.org id=B50179.162989266920908 (code B ref 50179); Wed, 25 Aug 2021 11:58:02 +0000 Original-Received: (at 50179) by debbugs.gnu.org; 25 Aug 2021 11:57:49 +0000 Original-Received: from localhost ([127.0.0.1]:45982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIrXQ-0005RA-Ll for submit@debbugs.gnu.org; Wed, 25 Aug 2021 07:57:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIrXP-0005Qy-KI for 50179@debbugs.gnu.org; Wed, 25 Aug 2021 07:57:47 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43888) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mIrXI-00030s-Nq; Wed, 25 Aug 2021 07:57:42 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3247 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIrXC-0005O9-8n; Wed, 25 Aug 2021 07:57:40 -0400 In-Reply-To: <87r1eic8as.fsf@gmail.com> (message from =?UTF-8?Q?K=C3=A9vin?= Le Gouguec on Wed, 25 Aug 2021 09:06:35 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212616 Archived-At: > From: Kévin Le Gouguec > Cc: Jim Porter , 50179@debbugs.gnu.org > Date: Wed, 25 Aug 2021 09:06:35 +0200 > > Eli Zaretskii writes: > > >> I made this a defcustom because `ansi-color-faces-vector' and > >> `ansi-color-names-vector' are defcustoms too. More practically > >> speaking, I'd want to customize this new variable to make these colors > >> match the Emacs theme I use. I chose colors in this patch to > >> complement `ansi-color-names-vector', but they'd clash with my theme. > > > > How can named colors change with the theme? Faces can, but colors are > > absolute. Bright-yellow is the same color whatever the theme. At > > least IMO. I wonder if others think otherwise. > > FWIW, a couple of Emacs's built-in themes set these ansi-color options. > See e.g. the Modus themes, which are designed to meet WCAG's highest > standards for colour contrast. It's OK to set a variable. I was asking why would we want to offer users the opportunity to customize these translations. > Maybe there's an analogy to make with terminal emulators? Most of those > (e.g. Konsole, Terminator, Xfce's) allow the user to customize the > 16-color palette. Once again, if someone _really_ wants that, they can set a variable allright. I'm asking why would _we_ want that. > Digging into the history of this 4-bit palette[1], it almost seems like > no two consoles ever used the exact same colors, so these color names > might not be as absolute as say, HTML color names[2]. I don't see how this justifies a desfcustom, sorry. If there's no 110% consensus, we can choose whatever similar color we want.