unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Michael Mauger <mmauger@protonmail.com>
Cc: psainty@orcon.net.nz, 31446@debbugs.gnu.org, fgunbin@fastmail.fm
Subject: bug#31446: 26.1; sql-interactive-mode buffer naming is broken
Date: Sun, 03 Jun 2018 19:30:39 +0300	[thread overview]
Message-ID: <83in6zde8g.fsf@gnu.org> (raw)
In-Reply-To: <UdmA4ypu2eDUXgaIk7jW4LsKqsqdPAkqGHX8JFM7w5qlOa0QA4MRIM4kud6I9TC9oKXxthdblelJ2RaTtqaZ8g==@protonmail.com> (message from Michael Mauger on Sat, 02 Jun 2018 19:47:17 -0400)

> Date: Sat, 02 Jun 2018 19:47:17 -0400
> From: Michael Mauger <mmauger@protonmail.com>
> 
> I have made a commit that fixes the buffer name handling. This code was 
> intended for 26.1 but obviously missed that. Please review it and let me
> know what you find.

Thanks.  Please in the future include in the log message a
ChangeLog-style list of specific changes you made.

> Outstanding work:
> * There is a bug around locating sql-interactive buffers from a sql buffer; I 
>    know how to fix it, just need to further test the code.
> * Rewrite the DOCSTRINGs to reflect the improved logic
> * Add code tests to limit regressions like this in the future
> * Add a Info file documenting sql-mode and the intended behavior.

Great, thanks in advance.





  reply	other threads:[~2018-06-03 16:30 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-14  5:54 bug#31446: 26.1; sql-interactive-mode buffer naming is broken Phil Sainty
2018-05-18  9:49 ` Eli Zaretskii
2018-05-18 12:19   ` Eli Zaretskii
2018-05-18 15:44     ` Filipp Gunbin
2018-05-18 16:04       ` Eli Zaretskii
2018-05-18 18:03         ` Filipp Gunbin
2018-05-18 20:24           ` Eli Zaretskii
     [not found]             ` <831se6hjnh.fsf@gnu.org>
2018-05-20 22:17               ` Phil Sainty
2018-05-21  2:35                 ` Eli Zaretskii
2018-05-21 12:09                   ` Phil Sainty
2018-05-21 15:45                     ` Eli Zaretskii
2018-05-21 22:08                       ` Phil Sainty
2018-05-22  2:37                         ` Eli Zaretskii
2018-05-22  4:01                           ` Phil Sainty
2018-05-20 23:53             ` Filipp Gunbin
2018-05-21 14:55               ` Eli Zaretskii
2018-05-22 11:27                 ` Filipp Gunbin
2018-05-22 16:42                   ` Eli Zaretskii
2018-05-22 19:15                     ` Filipp Gunbin
2018-05-23 13:48                       ` Michael Mauger
2018-05-29  7:52                         ` Filipp Gunbin
2018-05-29 14:36                           ` Michael Mauger
2018-05-29 16:49                             ` Eli Zaretskii
2018-05-29 19:48                             ` Filipp Gunbin
2018-05-29 23:32                             ` Phil Sainty
2018-05-30  2:51                               ` Michael Mauger
2018-05-30 16:43                                 ` Eli Zaretskii
2018-06-02 23:47                                   ` Michael Mauger
2018-06-03 16:30                                     ` Eli Zaretskii [this message]
2018-06-03 20:47                                       ` Michael Mauger
2018-06-04  2:32                                         ` Eli Zaretskii
2018-06-04 10:16                                     ` Phil Sainty
2018-06-04 17:45                                     ` Filipp Gunbin
2019-04-25  1:13 ` bug#31446: " Michael Mauger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83in6zde8g.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=31446@debbugs.gnu.org \
    --cc=fgunbin@fastmail.fm \
    --cc=mmauger@protonmail.com \
    --cc=psainty@orcon.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).