From: Filipp Gunbin <fgunbin@fastmail.fm>
To: Eli Zaretskii <eliz@gnu.org>
Cc: psainty@orcon.net.nz, 31446@debbugs.gnu.org
Subject: bug#31446: 26.1; sql-interactive-mode buffer naming is broken
Date: Fri, 18 May 2018 18:44:38 +0300 [thread overview]
Message-ID: <m27eo1q87t.fsf@fgunbin.playteam.ru> (raw)
In-Reply-To: <83bmddi2ad.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 18 May 2018 15:19:54 +0300")
On 18/05/2018 15:19 +0300, Eli Zaretskii wrote:
...
> (funcall (sql-get-product-feature product :sqli-comint-func)
> product
> (sql-get-product-feature product :sqli-options)
> - (if (and new-name (string-prefix-p "SQL" new-name t))
> - new-name
> - (concat "SQL: " new-name))))
> + (cond
> + ((zerop new-name)
> + "*SQL*")
> + ((stringp new-name)
> + (if (string-prefix-p "SQL" new-name t)
> + new-name
> + (concat "*SQL: " new-name "*")))
> + ((eq new-name '(4))
> + (sql-rename-buffer new-name)
> + sql-alternate-buffer-name)
> + (t
> + (format "*SQL: %s*" new-name)))))
...
But `sql-comint' (called from `sql-comint-postgres' and the like) has
logic which prepares buffer name (adding those asterisks etc.)
In `sql-product-interactive', `new-name', if set to '(4) from prefix, or
to some other value from argument, controls this:
(if (and (not new-name) buf)
(pop-to-buffer buf)
So if `new-name' is set, we shouldn't switch to existing buffer.
Maybe just pass `new-name' to comint func like this (undoing possible
setting of `new-name' to '(4) above), letting it do all the
name-choosing work?
(funcall (sql-get-product-feature product :sqli-comint-func)
product
(sql-get-product-feature product :sqli-options)
(if (equal '(4) new-name)
nil
new-name))
Filipp
next prev parent reply other threads:[~2018-05-18 15:44 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 5:54 bug#31446: 26.1; sql-interactive-mode buffer naming is broken Phil Sainty
2018-05-18 9:49 ` Eli Zaretskii
2018-05-18 12:19 ` Eli Zaretskii
2018-05-18 15:44 ` Filipp Gunbin [this message]
2018-05-18 16:04 ` Eli Zaretskii
2018-05-18 18:03 ` Filipp Gunbin
2018-05-18 20:24 ` Eli Zaretskii
[not found] ` <831se6hjnh.fsf@gnu.org>
2018-05-20 22:17 ` Phil Sainty
2018-05-21 2:35 ` Eli Zaretskii
2018-05-21 12:09 ` Phil Sainty
2018-05-21 15:45 ` Eli Zaretskii
2018-05-21 22:08 ` Phil Sainty
2018-05-22 2:37 ` Eli Zaretskii
2018-05-22 4:01 ` Phil Sainty
2018-05-20 23:53 ` Filipp Gunbin
2018-05-21 14:55 ` Eli Zaretskii
2018-05-22 11:27 ` Filipp Gunbin
2018-05-22 16:42 ` Eli Zaretskii
2018-05-22 19:15 ` Filipp Gunbin
2018-05-23 13:48 ` Michael Mauger
2018-05-29 7:52 ` Filipp Gunbin
2018-05-29 14:36 ` Michael Mauger
2018-05-29 16:49 ` Eli Zaretskii
2018-05-29 19:48 ` Filipp Gunbin
2018-05-29 23:32 ` Phil Sainty
2018-05-30 2:51 ` Michael Mauger
2018-05-30 16:43 ` Eli Zaretskii
2018-06-02 23:47 ` Michael Mauger
2018-06-03 16:30 ` Eli Zaretskii
2018-06-03 20:47 ` Michael Mauger
2018-06-04 2:32 ` Eli Zaretskii
2018-06-04 10:16 ` Phil Sainty
2018-06-04 17:45 ` Filipp Gunbin
2019-04-25 1:13 ` bug#31446: " Michael Mauger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m27eo1q87t.fsf@fgunbin.playteam.ru \
--to=fgunbin@fastmail.fm \
--cc=31446@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=psainty@orcon.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).