From: Phil Sainty <psainty@orcon.net.nz>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 31446@debbugs.gnu.org, fgunbin@fastmail.fm,
bug-gnu-emacs-bounces+psainty=orcon.net.nz@gnu.org,
michael@mauger.com
Subject: bug#31446: 26.1; sql-interactive-mode buffer naming is broken
Date: Tue, 22 May 2018 10:08:05 +1200 [thread overview]
Message-ID: <51c17257ab43917d561cc5e56a556d67@webmail.orcon.net.nz> (raw)
In-Reply-To: <83603hf1w9.fsf@gnu.org>
On 2018-05-22 03:45, Eli Zaretskii wrote:
> Thanks, I tried fixing it in a slightly different way, please take a
> look. I'd like to avoid releasing Emacs 26.1 with sql.el that was
> broken by latest changes.
That seems to work, except for regressing this bit:
>> I *think* we'd want (consp new-name) for that test (especially as
>> it ought to cover multiple uses of C-u)
With C-u C-u M-x sql-postgres I end up with buffer name "*SQL: (16)*"
and "Process SQL: (16) finished" etc.
Another difference from Emacs 25 is that using a prefix arg in Emacs 25
was guaranteed to create a new buffer/process (if the chosen buffer name
conflicted then it was uniquified), whereas the new code is switching to
the pre-existing buffer in the situation.
Calling `sql-rename-buffer' handles uniquification, and my suggested
code seems to be consistent with the old behaviour.
Hopefully Filipp (or others) can do some testing as well -- I've not
been
as thorough as I would like, so it would be good to have others
verifying
the changes too.
-Phil
As a side-note, I've just observed that killing SQLi buffers from the
`list-buffers' buffer triggers "error in process sentinel: Selecting
deleted buffer" after confirming that the process should be killed
(which prevents marking and killing *multiple* such buffers). I see
this also happens in Emacs 25, however.
next prev parent reply other threads:[~2018-05-21 22:08 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 5:54 bug#31446: 26.1; sql-interactive-mode buffer naming is broken Phil Sainty
2018-05-18 9:49 ` Eli Zaretskii
2018-05-18 12:19 ` Eli Zaretskii
2018-05-18 15:44 ` Filipp Gunbin
2018-05-18 16:04 ` Eli Zaretskii
2018-05-18 18:03 ` Filipp Gunbin
2018-05-18 20:24 ` Eli Zaretskii
[not found] ` <831se6hjnh.fsf@gnu.org>
2018-05-20 22:17 ` Phil Sainty
2018-05-21 2:35 ` Eli Zaretskii
2018-05-21 12:09 ` Phil Sainty
2018-05-21 15:45 ` Eli Zaretskii
2018-05-21 22:08 ` Phil Sainty [this message]
2018-05-22 2:37 ` Eli Zaretskii
2018-05-22 4:01 ` Phil Sainty
2018-05-20 23:53 ` Filipp Gunbin
2018-05-21 14:55 ` Eli Zaretskii
2018-05-22 11:27 ` Filipp Gunbin
2018-05-22 16:42 ` Eli Zaretskii
2018-05-22 19:15 ` Filipp Gunbin
2018-05-23 13:48 ` Michael Mauger
2018-05-29 7:52 ` Filipp Gunbin
2018-05-29 14:36 ` Michael Mauger
2018-05-29 16:49 ` Eli Zaretskii
2018-05-29 19:48 ` Filipp Gunbin
2018-05-29 23:32 ` Phil Sainty
2018-05-30 2:51 ` Michael Mauger
2018-05-30 16:43 ` Eli Zaretskii
2018-06-02 23:47 ` Michael Mauger
2018-06-03 16:30 ` Eli Zaretskii
2018-06-03 20:47 ` Michael Mauger
2018-06-04 2:32 ` Eli Zaretskii
2018-06-04 10:16 ` Phil Sainty
2018-06-04 17:45 ` Filipp Gunbin
2019-04-25 1:13 ` bug#31446: " Michael Mauger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51c17257ab43917d561cc5e56a556d67@webmail.orcon.net.nz \
--to=psainty@orcon.net.nz \
--cc=31446@debbugs.gnu.org \
--cc=bug-gnu-emacs-bounces+psainty=orcon.net.nz@gnu.org \
--cc=eliz@gnu.org \
--cc=fgunbin@fastmail.fm \
--cc=michael@mauger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).