From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31446: 26.1; sql-interactive-mode buffer naming is broken Date: Sun, 03 Jun 2018 19:30:39 +0300 Message-ID: <83in6zde8g.fsf@gnu.org> References: <83fu2jej5t.fsf@gnu.org> <834liphz6n.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1528043345 15030 195.159.176.226 (3 Jun 2018 16:29:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 3 Jun 2018 16:29:05 +0000 (UTC) Cc: psainty@orcon.net.nz, 31446@debbugs.gnu.org, fgunbin@fastmail.fm To: Michael Mauger Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 03 18:29:01 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPVsL-0003nj-0W for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jun 2018 18:29:01 +0200 Original-Received: from localhost ([::1]:35900 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPVuS-0006TL-7T for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jun 2018 12:31:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPVuL-0006T2-46 for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2018 12:31:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPVuH-00061L-W8 for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2018 12:31:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52571) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fPVuH-000619-SJ for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2018 12:31:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fPVuH-0001pk-N2 for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2018 12:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jun 2018 16:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31446-submit@debbugs.gnu.org id=B31446.15280434467020 (code B ref 31446); Sun, 03 Jun 2018 16:31:01 +0000 Original-Received: (at 31446) by debbugs.gnu.org; 3 Jun 2018 16:30:46 +0000 Original-Received: from localhost ([127.0.0.1]:60468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPVu1-0001pA-Pv for submit@debbugs.gnu.org; Sun, 03 Jun 2018 12:30:45 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPVu0-0001oy-H6 for 31446@debbugs.gnu.org; Sun, 03 Jun 2018 12:30:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPVtu-0005dh-Lg for 31446@debbugs.gnu.org; Sun, 03 Jun 2018 12:30:39 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33119) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPVtp-0005a0-VM; Sun, 03 Jun 2018 12:30:34 -0400 Original-Received: from [176.228.60.248] (port=4229 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fPVtp-0002O5-5x; Sun, 03 Jun 2018 12:30:33 -0400 In-reply-to: (message from Michael Mauger on Sat, 02 Jun 2018 19:47:17 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146914 Archived-At: > Date: Sat, 02 Jun 2018 19:47:17 -0400 > From: Michael Mauger > > I have made a commit that fixes the buffer name handling. This code was > intended for 26.1 but obviously missed that. Please review it and let me > know what you find. Thanks. Please in the future include in the log message a ChangeLog-style list of specific changes you made. > Outstanding work: > * There is a bug around locating sql-interactive buffers from a sql buffer; I > know how to fix it, just need to further test the code. > * Rewrite the DOCSTRINGs to reflect the improved logic > * Add code tests to limit regressions like this in the future > * Add a Info file documenting sql-mode and the intended behavior. Great, thanks in advance.