bug#51897: 29.0.50; keymap-global-unset cannot unset C-x C-z

bug#51897: 29.0.50; keymap-global-unset cannot unset C-x C-z

[Manuel Uberti via Bug reports for GNU Emacs, the Swiss army knife of text editors]

 From emacs -Q:

- M-x toggle-debug-on-error
- Evaluating (keymap-global-unset "C-x C-z") I get

Debugger entered--Lisp error: (error "Key sequence C - x SPC C - z starts with 
non-prefi...")
   keymap-unset((keymap #^[nil nil keymap #^^[3 0 set-mark-command 
move-beginning-of-line backward-char mode-specific-command-prefix delete-char 
move-end-of-line forward-char keyboard-quit help-command indent-for-tab-command 
electric-newline-and-maybe-indent kill-line recenter-top-bottom ...] #^^[1 0 
#^^[2 0 #^^[3 0 set-mark-command move-beginning-of-line backward-char 
mode-specific-command-prefix delete-char move-end-of-line forward-char 
keyboard-quit help-command indent-for-tab-command 
electric-newline-and-maybe-indent kill-line recenter-top-bottom ...] 
self-insert-command self-insert-command self-insert-command self-insert-command 
self-insert-command self-insert-command self-insert-command self-insert-command 
self-insert-command self-insert-command self-insert-command self-insert-command 
...] self-insert-command self-insert-command self-insert-command 
self-insert-command self-insert-command self-insert-command self-insert-command 
self-insert-command self-insert-command self-insert-command self-insert-command 
self-insert-command ...] self-insert-command self-insert-command 
self-insert-command self-insert-command self-insert-command self-insert-command 
self-insert-command self-insert-command self-insert-command ...] ... ... ... ... 
... ... ... ... ... ... ... ... ...) "C-x C-z" nil)
   keymap-global-unset("C-x C-z")
   (progn (keymap-global-unset "C-x C-z"))
   eval((progn (keymap-global-unset "C-x C-z")) t)
   elisp--eval-last-sexp(nil)
   eval-last-sexp(nil)
   funcall-interactively(eval-last-sexp nil)
   command-execute(eval-last-sexp)


Previously I was using (global-unset-key ["C-x C-z"]), which still works.


In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.18, cairo 
version 1.16.0)
  of 2021-11-16 built on hathaway
Repository revision: 4f47f10d9f8f3864fd37685b290e4ca5d339ba35
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12009000
System Description: Ubuntu 20.04 LTS

Configured using:
  'configure --with-harfbuzz --with-native-compilation'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES
NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF
TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB

Important settings:
   value of $LC_MESSAGES: en_GB.UTF-8
   value of $LC_MONETARY: it_IT.UTF-8
   value of $LC_NUMERIC: it_IT.UTF-8
   value of $LC_TIME: it_IT.UTF-8
   value of $LANG: en_US.UTF-8
   value of $XMODIFIERS: @im=ibus
   locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
   tooltip-mode: t
   global-eldoc-mode: t
   eldoc-mode: t
   show-paren-mode: t
   electric-indent-mode: t
   mouse-wheel-mode: t
   tool-bar-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t
   line-number-mode: t
   indent-tabs-mode: t
   transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media rmc puny
dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068
epg-config gnus-util rmail rmail-loaddefs auth-source eieio eieio-core
eieio-loaddefs password-cache json map text-property-search time-date
mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils
mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr
mail-utils help-fns radix-tree cl-print debug backtrace find-func
cus-start comp comp-cstr warnings rx cl-seq cl-macs cl-extra seq gv
subr-x byte-opt bytecomp byte-compile cconv cus-load help-mode
cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify
ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit x multi-tty make-network-process
native-compile emacs)

Memory information:
((conses 16 101454 7641)
  (symbols 48 9185 1)
  (strings 32 25266 3099)
  (string-bytes 1 821760)
  (vectors 16 17143)
  (vector-slots 8 297994 13136)
  (floats 8 31 39)
  (intervals 56 480 0)
  (buffers 992 13))

-- 
Manuel Uberti
www.manueluberti.eu

bug#51897: 29.0.50; keymap-global-unset cannot unset C-x C-z

[Manuel Uberti via Bug reports for GNU Emacs, the Swiss army knife of text editors]

I am also getting the same error if I do M-x keymap-global-unset.

-- 
Manuel Uberti
www.manueluberti.eu

bug#51897: 29.0.50; keymap-global-unset cannot unset C-x C-z

[Lars Ingebrigtsen]

Manuel Uberti via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:
> - M-x toggle-debug-on-error
> - Evaluating (keymap-global-unset "C-x C-z") I get
>
> Debugger entered--Lisp error: (error "Key sequence C - x SPC C - z
> starts with non-prefi...")
>   keymap-unset((keymap #^[nil nil keymap #^^[3 0 set-mark-command

This should now be fixed.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#51897: 29.0.50; keymap-global-unset cannot unset C-x C-z

[Manuel Uberti via Bug reports for GNU Emacs, the Swiss army knife of text editors]

On 16/11/21 19:42, Lars Ingebrigtsen wrote:
> This should now be fixed.

Do I need a make bootstrap, maybe?

-- 
Manuel Uberti
www.manueluberti.eu

bug#51897: 29.0.50; keymap-global-unset cannot unset C-x C-z

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Tue, 16 Nov 2021 19:42:40 +0100
> Cc: manuel.uberti@inventati.org
> 
> Manuel Uberti via "Bug reports for GNU Emacs, the Swiss army knife of
> text editors" <bug-gnu-emacs@gnu.org> writes:
> > - M-x toggle-debug-on-error
> > - Evaluating (keymap-global-unset "C-x C-z") I get
> >
> > Debugger entered--Lisp error: (error "Key sequence C - x SPC C - z
> > starts with non-prefi...")
> >   keymap-unset((keymap #^[nil nil keymap #^^[3 0 set-mark-command
> 
> This should now be fixed.

Did you forget to push, per chance?

bug#51897: 29.0.50; keymap-global-unset cannot unset C-x C-z

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> Did you forget to push, per chance?

*sigh*  I did indeed.

Perhaps I should make vc pull+push automatically after checking in or
something.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#51897: 29.0.50; keymap-global-unset cannot unset C-x C-z

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: 51897@debbugs.gnu.org,  manuel.uberti@inventati.org
> Date: Tue, 16 Nov 2021 20:02:12 +0100
> 
> > Did you forget to push, per chance?
> 
> *sigh*  I did indeed.
> 
> Perhaps I should make vc pull+push automatically after checking in or
> something.

Are you using "C-x v v", perhaps?  At some point in the past I
proposed to teach "C-x v v" to suggest a push after commit, or even
optionally do a push without asking, given some user customization.
But that idea was shot down for reasons I still don't understand.
I think keeping push out of the "C-x v v" cycle makes that command
much less useful nowadays.

bug#51897: 29.0.50; keymap-global-unset cannot unset C-x C-z

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> Are you using "C-x v v", perhaps?  At some point in the past I
> proposed to teach "C-x v v" to suggest a push after commit, or even
> optionally do a push without asking, given some user customization.
> But that idea was shot down for reasons I still don't understand.
> I think keeping push out of the "C-x v v" cycle makes that command
> much less useful nowadays.

I do see the objection from a standpoint of "well, a commit and a push
are two totally separate operations" Git standpoint, but I think it
might be helpful to have as an option.

After thinking about it a bit more, I'm not quite sure what I'd prefer
myself.  It's not uncommon for me that I remember something after I've
hit `C-x v v' (like adding Copyright-paperwork-exempt: yes to the commit
message), and having this be a two step operation helps with that,
because I can just back out the commit and try again, which I can't if
I've already pushed.

But on the other hand, I forget to push so often that it's ridiculous.
I think one of the contributing factors is that it just takes a while --
I mean, I have to pull first, wait for it to finish, and then push.
Perhaps I should just make a command that does both pull (and if there's
no errors) and a push.  I think I'll try to experiment a bit and try to
see if there's anything that can be generalised as a vc command.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#51897: 29.0.50; keymap-global-unset cannot unset C-x C-z

[Juri Linkov]

> After thinking about it a bit more, I'm not quite sure what I'd prefer
> myself.  It's not uncommon for me that I remember something after I've
> hit `C-x v v' (like adding Copyright-paperwork-exempt: yes to the commit
> message), and having this be a two step operation helps with that,
> because I can just back out the commit and try again, which I can't if
> I've already pushed.

Also there is a useful feature 'vc-git-log-edit-toggle-amend'
to amend the last commit before pushing.

Maybe 'C-x v v' could just display a reminder message like
"Don't forget to push your commits"?

bug#51897: 29.0.50; keymap-global-unset cannot unset C-x C-z

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: 51897@debbugs.gnu.org,  manuel.uberti@inventati.org
> Date: Wed, 17 Nov 2021 08:53:32 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Are you using "C-x v v", perhaps?  At some point in the past I
> > proposed to teach "C-x v v" to suggest a push after commit, or even
> > optionally do a push without asking, given some user customization.
> > But that idea was shot down for reasons I still don't understand.
> > I think keeping push out of the "C-x v v" cycle makes that command
> > much less useful nowadays.
> 
> I do see the objection from a standpoint of "well, a commit and a push
> are two totally separate operations" Git standpoint

I didn't suggest to do them both in one go, I suggested that invoking
"C-x v v" _after_ the one that committed a changeset will either push
or offer pushing as one of a small number of possible actions.

> After thinking about it a bit more, I'm not quite sure what I'd prefer
> myself.  It's not uncommon for me that I remember something after I've
> hit `C-x v v' (like adding Copyright-paperwork-exempt: yes to the commit
> message), and having this be a two step operation helps with that,
> because I can just back out the commit and try again, which I can't if
> I've already pushed.

What is reasonable after a commit?  Either (a) show or (b) push or (c)
another commit or (d) pull.  So why not ask the user which one of
these would he/she want to do?  We could even try to be smart about
that: for example, if the clone is ahead of upstream, push might be
the moist reasonable possibility.

What does "C-x v v" do today after push?  If the tree is clean,
nothing useful.  So what are we going to lose?

> But on the other hand, I forget to push so often that it's ridiculous.
> I think one of the contributing factors is that it just takes a while --
> I mean, I have to pull first, wait for it to finish, and then push.

For that reason, I never pull before pushing, unless push tells me I
must.

bug#51897: 29.0.50; keymap-global-unset cannot unset C-x C-z

[Lars Ingebrigtsen]

Juri Linkov <juri@linkov.net> writes:

> Also there is a useful feature 'vc-git-log-edit-toggle-amend'
> to amend the last commit before pushing.

Thanks; didn't know about that one.

> Maybe 'C-x v v' could just display a reminder message like
> "Don't forget to push your commits"?

Perhaps I can experiment with reminders running off of
`vc-checkin-hook'.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#51897: 29.0.50; keymap-global-unset cannot unset C-x C-z

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> I didn't suggest to do them both in one go, I suggested that invoking
> "C-x v v" _after_ the one that committed a changeset will either push
> or offer pushing as one of a small number of possible actions.

Oh, I see.  Yes, that makes sense to me.  `C-x v v' in that state
doesn't seem to do anything useful.  I tried it now, and it said:

Registering (/home/larsi/src/emacs/trunk/)... done

Which...  is both confusing and not useful?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#51897: 29.0.50; keymap-global-unset cannot unset C-x C-z

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: 51897@debbugs.gnu.org,  manuel.uberti@inventati.org
> Date: Thu, 18 Nov 2021 10:19:37 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > I didn't suggest to do them both in one go, I suggested that invoking
> > "C-x v v" _after_ the one that committed a changeset will either push
> > or offer pushing as one of a small number of possible actions.
> 
> Oh, I see.  Yes, that makes sense to me.  `C-x v v' in that state
> doesn't seem to do anything useful.  I tried it now, and it said:
> 
> Registering (/home/larsi/src/emacs/trunk/)... done
> 
> Which...  is both confusing and not useful?

Yes, I think both.