From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51897: 29.0.50; keymap-global-unset cannot unset C-x C-z Date: Wed, 17 Nov 2021 15:59:38 +0200 Message-ID: <83k0h6zxv9.fsf@gnu.org> References: <97c62cc1-dbaf-a747-5a52-0f5b217850dd@inventati.org> <87sfvwq6vz.fsf@gnus.org> <831r3g0wel.fsf@gnu.org> <87mtm3rkjv.fsf@gnus.org> <83zgq3zz6j.fsf@gnu.org> <87ilwrp69v.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19344"; mail-complaints-to="usenet@ciao.gmane.io" Cc: manuel.uberti@inventati.org, 51897@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 17 15:01:40 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnLVM-0004pX-4l for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Nov 2021 15:01:40 +0100 Original-Received: from localhost ([::1]:48004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnLVK-0007c8-BS for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Nov 2021 09:01:38 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44486) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnLTn-0006Nl-2p for bug-gnu-emacs@gnu.org; Wed, 17 Nov 2021 09:00:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48915) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mnLTm-0001Cs-R5 for bug-gnu-emacs@gnu.org; Wed, 17 Nov 2021 09:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mnLTm-0001m0-OW for bug-gnu-emacs@gnu.org; Wed, 17 Nov 2021 09:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Nov 2021 14:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51897 X-GNU-PR-Package: emacs Original-Received: via spool by 51897-submit@debbugs.gnu.org id=B51897.16371575956769 (code B ref 51897); Wed, 17 Nov 2021 14:00:02 +0000 Original-Received: (at 51897) by debbugs.gnu.org; 17 Nov 2021 13:59:55 +0000 Original-Received: from localhost ([127.0.0.1]:60461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnLTf-0001l7-Fk for submit@debbugs.gnu.org; Wed, 17 Nov 2021 08:59:55 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnLTa-0001kl-OP for 51897@debbugs.gnu.org; Wed, 17 Nov 2021 08:59:54 -0500 Original-Received: from [2001:470:142:3::e] (port=60472 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnLTU-00018C-Iq; Wed, 17 Nov 2021 08:59:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=46xHdEqWeSBmTs+NdH/SP0gNz18nZbrjwowf5Tqw59w=; b=hmDdX63oAzkE mTEwnz2OSAQT/344Z8kBThGdegGuN+trr5pZacTf5n+yHNxVOm6Wpzw10G28eFc3KnedrJLCEy+jp eGteEzBW+rkLlFqpBcvkGNPtDRl/I5KwFbPrOD0BduQUCtXMYUdYvRgDRB76OsbYAAKYMjda26DTW J1NAgDAlr4gWXblzNLcSCjLvEm7Rhmij20VdZG2UHAVWgYcP2f5+RJFdTrVRsqHmktrDmnLl3EbvT TG8JqJoQHopfmBUwCypdpLopsuL+QayzsLb6OW1Z4f+51F4abm/y6d3bhstArt+yshXNldXGFx4uX Y4I6+z83Z0lQbqzMudzGOA==; Original-Received: from [87.69.77.57] (port=3902 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnLTU-00078m-6b; Wed, 17 Nov 2021 08:59:44 -0500 In-Reply-To: <87ilwrp69v.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed, 17 Nov 2021 08:53:32 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220203 Archived-At: > From: Lars Ingebrigtsen > Cc: 51897@debbugs.gnu.org, manuel.uberti@inventati.org > Date: Wed, 17 Nov 2021 08:53:32 +0100 > > Eli Zaretskii writes: > > > Are you using "C-x v v", perhaps? At some point in the past I > > proposed to teach "C-x v v" to suggest a push after commit, or even > > optionally do a push without asking, given some user customization. > > But that idea was shot down for reasons I still don't understand. > > I think keeping push out of the "C-x v v" cycle makes that command > > much less useful nowadays. > > I do see the objection from a standpoint of "well, a commit and a push > are two totally separate operations" Git standpoint I didn't suggest to do them both in one go, I suggested that invoking "C-x v v" _after_ the one that committed a changeset will either push or offer pushing as one of a small number of possible actions. > After thinking about it a bit more, I'm not quite sure what I'd prefer > myself. It's not uncommon for me that I remember something after I've > hit `C-x v v' (like adding Copyright-paperwork-exempt: yes to the commit > message), and having this be a two step operation helps with that, > because I can just back out the commit and try again, which I can't if > I've already pushed. What is reasonable after a commit? Either (a) show or (b) push or (c) another commit or (d) pull. So why not ask the user which one of these would he/she want to do? We could even try to be smart about that: for example, if the clone is ahead of upstream, push might be the moist reasonable possibility. What does "C-x v v" do today after push? If the tree is clean, nothing useful. So what are we going to lose? > But on the other hand, I forget to push so often that it's ridiculous. > I think one of the contributing factors is that it just takes a while -- > I mean, I have to pull first, wait for it to finish, and then push. For that reason, I never pull before pushing, unless push tells me I must.