From: Eli Zaretskii <eliz@gnu.org>
To: Leo Liu <sdl.web@gmail.com>,
Stefan Monnier <monnier@iro.umontreal.ca>,
Lars Ingebrigtsen <larsi@gnus.org>
Cc: 45610@debbugs.gnu.org
Subject: bug#45610: 27.1; Symbol’s function definition is void: seq-concatenate
Date: Sat, 02 Jan 2021 18:30:49 +0200 [thread overview]
Message-ID: <83eej3e1xi.fsf@gnu.org> (raw)
In-Reply-To: <m1k0sv490s.fsf@gmail.com> (message from Leo Liu on Sun, 03 Jan 2021 00:07:47 +0800)
> From: Leo Liu <sdl.web@gmail.com>
> Cc: 45610@debbugs.gnu.org
> Date: Sun, 03 Jan 2021 00:07:47 +0800
>
> On 2021-01-02 16:25 +0200, Eli Zaretskii wrote:
> > Thanks. Then does the patch below fix the problem in Emacs 27.1?
>
> Yes it does.
Then I'd like to push this fix to the release branch, but...
> > (defun cl-concatenate (type &rest sequences)
> > "Concatenate, into a sequence of type TYPE, the argument SEQUENCEs.
> > \n(fn TYPE SEQUENCE...)"
> > + (require 'seq)
> > (apply #'seq-concatenate type sequences))
> >
> > ;;; List functions.
>
> But it seems the function will become slower when called regularly
> because of the (require 'seq).
...slightly, yes.
> Is it better to remove cl-concatenate from the cl-proclaim list in
> cl-macs.el?
Wouldn't that make it even slower? And cause incompatibilities with
already byte-compiled files that saw the original cl-macs.el?
But I'm not an expert on these issues, so I'l defer to Stefan and Lars
here.
next prev parent reply other threads:[~2021-01-02 16:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-02 12:29 bug#45610: 27.1; Symbol’s function definition is void: seq-concatenate Leo Liu
2021-01-02 12:47 ` Eli Zaretskii
2021-01-02 14:22 ` Leo Liu
2021-01-02 14:25 ` Eli Zaretskii
2021-01-02 16:07 ` Leo Liu
2021-01-02 16:30 ` Eli Zaretskii [this message]
2021-01-02 16:35 ` Lars Ingebrigtsen
2021-01-03 15:46 ` Eli Zaretskii
2021-01-03 16:19 ` Leo Liu
2021-01-04 5:39 ` Leo Liu
2021-01-04 15:07 ` Eli Zaretskii
2021-01-04 17:35 ` Stefan Monnier
2021-01-09 12:13 ` Eli Zaretskii
2021-01-02 16:45 ` Leo Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83eej3e1xi.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=45610@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).