From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#45610: 27.1; =?UTF-8?Q?Symbol=E2=80=99s?= function definition is void: seq-concatenate Date: Sat, 02 Jan 2021 18:30:49 +0200 Message-ID: <83eej3e1xi.fsf@gnu.org> References: <83v9cfecab.fsf@gnu.org> <83r1n3e7ps.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15835"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45610@debbugs.gnu.org To: Leo Liu , Stefan Monnier , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 02 17:32:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kvjp3-00041G-Sl for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Jan 2021 17:32:09 +0100 Original-Received: from localhost ([::1]:58380 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kvjp2-00062h-Tw for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Jan 2021 11:32:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvjow-00062L-6x for bug-gnu-emacs@gnu.org; Sat, 02 Jan 2021 11:32:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48938) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kvjov-0003Zj-W3 for bug-gnu-emacs@gnu.org; Sat, 02 Jan 2021 11:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kvjov-0003MV-Sv for bug-gnu-emacs@gnu.org; Sat, 02 Jan 2021 11:32:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Jan 2021 16:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45610 X-GNU-PR-Package: emacs Original-Received: via spool by 45610-submit@debbugs.gnu.org id=B45610.160960507212864 (code B ref 45610); Sat, 02 Jan 2021 16:32:01 +0000 Original-Received: (at 45610) by debbugs.gnu.org; 2 Jan 2021 16:31:12 +0000 Original-Received: from localhost ([127.0.0.1]:60484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvjo8-0003LQ-4h for submit@debbugs.gnu.org; Sat, 02 Jan 2021 11:31:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvjo6-0003LD-4B for 45610@debbugs.gnu.org; Sat, 02 Jan 2021 11:31:10 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56024) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kvjo0-0003V8-Fp; Sat, 02 Jan 2021 11:31:04 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2584 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kvjnz-0001yX-KQ; Sat, 02 Jan 2021 11:31:04 -0500 In-Reply-To: (message from Leo Liu on Sun, 03 Jan 2021 00:07:47 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197197 Archived-At: > From: Leo Liu > Cc: 45610@debbugs.gnu.org > Date: Sun, 03 Jan 2021 00:07:47 +0800 > > On 2021-01-02 16:25 +0200, Eli Zaretskii wrote: > > Thanks. Then does the patch below fix the problem in Emacs 27.1? > > Yes it does. Then I'd like to push this fix to the release branch, but... > > (defun cl-concatenate (type &rest sequences) > > "Concatenate, into a sequence of type TYPE, the argument SEQUENCEs. > > \n(fn TYPE SEQUENCE...)" > > + (require 'seq) > > (apply #'seq-concatenate type sequences)) > > > > ;;; List functions. > > But it seems the function will become slower when called regularly > because of the (require 'seq). ...slightly, yes. > Is it better to remove cl-concatenate from the cl-proclaim list in > cl-macs.el? Wouldn't that make it even slower? And cause incompatibilities with already byte-compiled files that saw the original cl-macs.el? But I'm not an expert on these issues, so I'l defer to Stefan and Lars here.