unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Leo Liu <sdl.web@gmail.com>
Cc: larsi@gnus.org, 45610@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#45610: 27.1; Symbol’s function definition is void: seq-concatenate
Date: Mon, 04 Jan 2021 17:07:08 +0200	[thread overview]
Message-ID: <83y2h8bv1f.fsf@gnu.org> (raw)
In-Reply-To: <m14kjx45xk.fsf@gmail.com> (message from Leo Liu on Mon, 04 Jan 2021 13:39:03 +0800)

> From:  Leo Liu <sdl.web@gmail.com>
> Cc: Lars Ingebrigtsen <larsi@gnus.org>,  45610@debbugs.gnu.org,  monnier@iro.umontreal.ca
> Date: Mon, 04 Jan 2021 13:39:03 +0800
> 
> On 2021-01-03 17:46 +0200, Eli Zaretskii wrote:
> > In your opinion, is this better than my suggestion?
> 
> I didn't comment much on this point last night.
> 
> Adding (require 'seq) to cl-concatenate is probably the least favourable
> because it also defeats the purpose of the `inline' cl-proclaim.
> 
> Adding autoload cookie for seq-concatenate is simple though not the
> cleanest, IOW, we have the workings of cl-concatenate in some situations
> depend on the autoload cookie. But this is not uncommon practice.
> 
> Given the dilemma we are in I wonder if the considerations for `inline'
> cl-concatenate in the first place are no longer applicable.

Thanks.

Stefan, any comments?  My personal tendency is to add the autoload
cookie, with a comment saying that cl-concatenate needs that.  At
least on the emacs-27 branch.  Any problems or issues with that?  What
do people think about removing cl-concatenate from the inline
declaration (on master)?





  reply	other threads:[~2021-01-04 15:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-02 12:29 bug#45610: 27.1; Symbol’s function definition is void: seq-concatenate Leo Liu
2021-01-02 12:47 ` Eli Zaretskii
2021-01-02 14:22   ` Leo Liu
2021-01-02 14:25     ` Eli Zaretskii
2021-01-02 16:07       ` Leo Liu
2021-01-02 16:30         ` Eli Zaretskii
2021-01-02 16:35           ` Lars Ingebrigtsen
2021-01-03 15:46             ` Eli Zaretskii
2021-01-03 16:19               ` Leo Liu
2021-01-04  5:39               ` Leo Liu
2021-01-04 15:07                 ` Eli Zaretskii [this message]
2021-01-04 17:35                   ` Stefan Monnier
2021-01-09 12:13                     ` Eli Zaretskii
2021-01-02 16:45           ` Leo Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y2h8bv1f.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=45610@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).