unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Leo Liu <sdl.web@gmail.com>
Cc: 45610@debbugs.gnu.org
Subject: bug#45610: 27.1; Symbol’s function definition is void: seq-concatenate
Date: Sat, 02 Jan 2021 16:25:51 +0200	[thread overview]
Message-ID: <83r1n3e7ps.fsf@gnu.org> (raw)
In-Reply-To: <m1o8i74dw4.fsf@gmail.com> (message from Leo Liu on Sat, 02 Jan 2021 22:22:35 +0800)

> From:  Leo Liu <sdl.web@gmail.com>
> Cc: 45610@debbugs.gnu.org
> Date: Sat, 02 Jan 2021 22:22:35 +0800
> 
> On 2021-01-02 14:47 +0200, Eli Zaretskii wrote:
> > What did that expand to in Emacs 26?
> 
> The body of cl-concatenate before Emacs 27:
> 
> (pcase type
>    (`vector (apply #'vconcat sequences))
>    (`string (apply #'concat sequences))
>    (`list (apply #'append (append sequences '(nil))))
>    (_ (error "Not a sequence type name: %S" type)))

Thanks.  Then does the patch below fix the problem in Emacs 27.1?

diff --git a/lisp/emacs-lisp/cl-extra.el b/lisp/emacs-lisp/cl-extra.el
index 9c9da4a..a6e6619 100644
--- a/lisp/emacs-lisp/cl-extra.el
+++ b/lisp/emacs-lisp/cl-extra.el
@@ -556,6 +556,7 @@ cl-subseq
 (defun cl-concatenate (type &rest sequences)
   "Concatenate, into a sequence of type TYPE, the argument SEQUENCEs.
 \n(fn TYPE SEQUENCE...)"
+  (require 'seq)
   (apply #'seq-concatenate type sequences))
 
 ;;; List functions.





  reply	other threads:[~2021-01-02 14:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-02 12:29 bug#45610: 27.1; Symbol’s function definition is void: seq-concatenate Leo Liu
2021-01-02 12:47 ` Eli Zaretskii
2021-01-02 14:22   ` Leo Liu
2021-01-02 14:25     ` Eli Zaretskii [this message]
2021-01-02 16:07       ` Leo Liu
2021-01-02 16:30         ` Eli Zaretskii
2021-01-02 16:35           ` Lars Ingebrigtsen
2021-01-03 15:46             ` Eli Zaretskii
2021-01-03 16:19               ` Leo Liu
2021-01-04  5:39               ` Leo Liu
2021-01-04 15:07                 ` Eli Zaretskii
2021-01-04 17:35                   ` Stefan Monnier
2021-01-09 12:13                     ` Eli Zaretskii
2021-01-02 16:45           ` Leo Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r1n3e7ps.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=45610@debbugs.gnu.org \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).