From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: jporterbugs@gmail.com, philipk@posteo.net, 62720@debbugs.gnu.org,
monnier@iro.umontreal.ca, larsi@gnus.org, joaotavora@gmail.com
Subject: bug#62720: 29.0.60; Not easy at all to upgrade :core packages like Eglot
Date: Sat, 22 Apr 2023 15:00:29 +0300 [thread overview]
Message-ID: <83edoc1602.fsf@gnu.org> (raw)
In-Reply-To: <6e91a10e-e8bb-c7db-f6ce-917790e7e391@gutov.dev> (message from Dmitry Gutov on Sat, 22 Apr 2023 14:24:47 +0300)
> Date: Sat, 22 Apr 2023 14:24:47 +0300
> Cc: jporterbugs@gmail.com, philipk@posteo.net, 62720@debbugs.gnu.org,
> joaotavora@gmail.com, larsi@gnus.org, monnier@iro.umontreal.ca
> From: Dmitry Gutov <dmitry@gutov.dev>
>
> On 22/04/2023 14:11, Eli Zaretskii wrote:
> >> Date: Sat, 22 Apr 2023 13:30:41 +0300
> >> Cc: jporterbugs@gmail.com, philipk@posteo.net, 62720@debbugs.gnu.org,
> >> joaotavora@gmail.com, larsi@gnus.org, monnier@iro.umontreal.ca
> >> From: Dmitry Gutov <dmitry@gutov.dev>
> >>
> >>> Thanks, but this is not what was being discussed, AFAIU. What I said
> >>> I'd agree to is to have package-update accept a prefix argument and
> >>> heed package-install-upgrade-built-in (perhaps renamed),
> >>
> >> I think I explained in the previous email why reusing
> >> package-install-upgrade-built-in doesn't seem like a good idea.
> >
> > And I thought I've explained why I didn't see a need for another
> > option.
>
> I also don't see the point of using an option here.
We must not change past behavior unconditionally and by default, not
this close to the release.
> Also think forward to Emacs 30: I think the most reasonable choice would
> be to have package-update upgrade builtins by default, whereas
> package-update-all and package-menu-mark-for-upgrades probably still
> need to be preffed off (not sure, but we won't be able to make the
> choice until later, I think).
I don't see why package-update and package-update-all should behave
differently wrt core packages. If the user expresses his/her will to
update core packages, then package-update-all should do this for all
of them.
> But if to make package-update behave properly we need to flip the
> default of the said option, it will flip the behavior of
> package-update-all and package-menu-mark-for-upgrades as well.
Which is how it should be, IMO.
> >>> and only then
> >>> update built-in packages.
> >>
> >> I asked what plausible scenario you think might be broken by having
> >> package-update upgrade builtin package by default.
> >
> > That's obvious: this is how package-update behaved until now.
>
> That's not an answer to the question.
It is for me (and I'm quite surprised that it is not for you).
> >>> I also don't think I like the significant changes in package-update,
> >>> nor understand why they are needed.
> >>
> >> Like I said: the changes are to avoid relying on package-install being
> >> able to install a package that's already installed. Which currently
> >> works only for builtins and when only a user option is set. It's a mess.
> >>
> >> And to "avoid interdependency".
> >
> > Why does this have to be in Emacs 29? It's a cleanup, right?
>
> Not a cleanup, no. If I just keep the previous version of the code, I
> get "package xxx is already installed". Because when upgrading a builtin
> package, the "current" version is not deleted.
>
> So we need to compute the exact version to install (then package-install
> does not say "it's already installed" because the installed version is
> different). The use of package-install-from-archive might have been a
> mistake, though, (in case dependencies need to be updated too) I'm
> looking into that now.
With prefix argument, or when package-update-built-in is non-nil, the
behavior of package-install is different. So just use this, instead
of changing the code of package-update.
> Alternatively, we could add an optional argument to package-install
> which would mean "install the latest version anyway".
There is already such an option, added as part of fixing this bug.
> >> Just to be clear, we are talking about the 4 lines at the end, right?
> >
> > Yes, and also the (somewhat mysterious) additions of tests for
> > pkg-desc.
>
> pkg-desc is nil for builtin packages in this case (they are not in
> package-alist, so (assq package package-alist) returns nil).
This should either be commented, or a variable with a telltale name
added to reflect this subtlety.
next prev parent reply other threads:[~2023-04-22 12:00 UTC|newest]
Thread overview: 278+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 22:12 bug#62720: 29.0.60; Not easy at all to upgrade :core packages like Eglot João Távora
2023-04-08 1:03 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-08 10:43 ` Philip Kaludercic
2023-04-08 10:48 ` João Távora
2023-04-08 14:42 ` Philip Kaludercic
2023-04-08 15:25 ` João Távora
2023-04-08 15:45 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-10 16:01 ` João Távora
2023-04-10 18:13 ` Philip Kaludercic
2023-04-11 11:02 ` João Távora
2023-04-11 11:40 ` Eli Zaretskii
2023-04-11 12:52 ` João Távora
2023-04-11 17:55 ` Eli Zaretskii
2023-04-11 18:31 ` João Távora
2023-04-11 18:52 ` Eli Zaretskii
2023-04-11 20:08 ` João Távora
2023-04-11 20:25 ` João Távora
2023-04-12 5:49 ` Eli Zaretskii
2023-04-12 7:58 ` João Távora
2023-04-12 8:19 ` Eli Zaretskii
2023-04-12 8:51 ` João Távora
2023-04-12 10:23 ` Eli Zaretskii
2023-04-12 10:38 ` João Távora
2023-04-12 11:01 ` Eli Zaretskii
2023-04-12 11:00 ` João Távora
2023-04-12 11:08 ` Eli Zaretskii
2023-04-12 11:15 ` João Távora
2023-04-12 11:22 ` Eli Zaretskii
2023-04-12 11:35 ` João Távora
2023-04-12 11:47 ` Eli Zaretskii
2023-04-12 12:01 ` João Távora
2023-04-12 12:00 ` Philip Kaludercic
2023-04-12 12:18 ` João Távora
2023-04-12 12:28 ` Philip Kaludercic
2023-04-12 12:55 ` João Távora
2023-04-12 12:30 ` Eli Zaretskii
2023-04-12 13:42 ` Philip Kaludercic
2023-04-12 14:11 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-12 14:14 ` João Távora
2023-04-12 14:17 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-12 14:20 ` João Távora
2023-04-12 15:18 ` Eli Zaretskii
2023-04-12 16:13 ` João Távora
2023-04-12 16:16 ` João Távora
2023-04-12 16:53 ` Eli Zaretskii
2023-04-12 17:14 ` João Távora
2023-04-12 17:22 ` Eli Zaretskii
2023-04-12 17:43 ` João Távora
2023-04-12 19:09 ` Eli Zaretskii
2023-04-12 19:39 ` Philip Kaludercic
2023-04-13 5:30 ` Eli Zaretskii
2023-04-13 7:38 ` Philip Kaludercic
2023-04-13 8:11 ` Eli Zaretskii
2023-04-13 11:23 ` Philip Kaludercic
2023-04-13 15:03 ` Eli Zaretskii
2023-04-13 15:10 ` Philip Kaludercic
2023-04-13 15:56 ` Eli Zaretskii
2023-04-13 17:49 ` Philip Kaludercic
2023-04-13 18:15 ` Eli Zaretskii
2023-04-13 18:49 ` Philip Kaludercic
2023-04-14 10:54 ` Eli Zaretskii
2023-04-14 12:34 ` Robert Pluim
2023-04-14 12:56 ` João Távora
2023-04-14 13:52 ` Robert Pluim
2023-04-14 15:34 ` João Távora
2023-04-14 15:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-14 16:05 ` João Távora
2023-04-14 16:28 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-14 16:34 ` Dmitry Gutov
2023-04-14 16:40 ` João Távora
2023-04-14 16:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-14 17:49 ` Eli Zaretskii
2023-04-14 18:32 ` João Távora
2023-04-14 18:49 ` Eli Zaretskii
2023-04-14 19:03 ` João Távora
2023-04-14 19:18 ` Eli Zaretskii
2023-04-14 19:31 ` João Távora
2023-04-14 16:12 ` Dmitry Gutov
2023-04-14 16:31 ` João Távora
2023-04-14 16:54 ` Philip Kaludercic
2023-04-14 17:32 ` João Távora
2023-04-14 18:27 ` Philip Kaludercic
2023-04-14 18:39 ` João Távora
2023-04-14 19:33 ` Philip Kaludercic
2023-04-14 19:48 ` João Távora
2023-04-14 17:53 ` Eli Zaretskii
2023-04-14 18:44 ` João Távora
2023-04-14 18:51 ` Eli Zaretskii
2023-04-14 19:14 ` Dmitry Gutov
2023-04-14 19:19 ` Eli Zaretskii
2023-04-14 19:21 ` Dmitry Gutov
2023-04-14 19:30 ` Eli Zaretskii
2023-04-14 19:34 ` João Távora
2023-04-14 19:20 ` João Távora
2023-04-14 19:28 ` Eli Zaretskii
2023-04-14 19:46 ` João Távora
2023-04-14 20:04 ` Philip Kaludercic
2023-04-15 8:35 ` João Távora
2023-04-15 10:40 ` Philip Kaludercic
2023-04-15 10:44 ` João Távora
2023-04-15 12:34 ` Dmitry Gutov
2023-04-15 9:03 ` Eli Zaretskii
2023-04-15 10:24 ` João Távora
2023-04-15 10:28 ` Eli Zaretskii
2023-04-15 11:19 ` Kévin Le Gouguec
2023-04-15 12:33 ` Dmitry Gutov
2023-04-15 13:36 ` João Távora
2023-04-15 16:53 ` Philip Kaludercic
2023-04-15 21:16 ` Kévin Le Gouguec
2023-04-16 10:23 ` João Távora
2023-04-16 20:46 ` Dmitry Gutov
2023-04-16 21:54 ` João Távora
2023-04-17 2:30 ` Eli Zaretskii
2023-04-17 2:24 ` Eli Zaretskii
2023-04-18 1:25 ` Dmitry Gutov
2023-04-18 11:44 ` João Távora
2023-04-18 20:38 ` Dmitry Gutov
2023-04-18 20:56 ` João Távora
2023-04-18 21:06 ` Dmitry Gutov
2023-04-18 21:15 ` João Távora
2023-04-18 21:20 ` Dmitry Gutov
2023-04-19 12:05 ` Eli Zaretskii
2023-04-19 13:04 ` João Távora
2023-04-19 13:35 ` Eli Zaretskii
2023-04-19 14:04 ` João Távora
2023-04-19 16:02 ` Eli Zaretskii
2023-04-19 16:17 ` João Távora
2023-04-19 15:48 ` Dmitry Gutov
2023-04-19 16:10 ` Eli Zaretskii
2023-04-19 16:23 ` João Távora
2023-04-19 16:50 ` Eli Zaretskii
2023-04-19 17:27 ` João Távora
2023-04-19 18:00 ` Eli Zaretskii
2023-04-19 18:27 ` João Távora
2023-04-19 18:48 ` Eli Zaretskii
2023-04-19 17:23 ` Dmitry Gutov
2023-04-19 17:53 ` Eli Zaretskii
[not found] ` <83r0sh8i1q.fsf@gnu.org>
[not found] ` <35638c9d-e13f-fad8-5f95-ea03d65d4aa2@gmail.com>
[not found] ` <CALDnm53J-HnUz26thrMbFXEARE8yiOJiBb2M75Qm3KKnxRxWzQ@mail.gmail.com>
[not found] ` <87a5z3izst.fsf@web.de>
[not found] ` <83v8hr7qk9.fsf@gnu.org>
[not found] ` <CALDnm51zZw4JhnxCEUApN0N-90c08d-jOct5i2xcTMOhBb78=g@mail.gmail.com>
[not found] ` <83pm7z7nkc.fsf@gnu.org>
[not found] ` <4b63ef62-5e1c-3dcf-ec7b-06b69e79133b@gutov.dev>
[not found] ` <83o7nj7mfn.fsf@gnu.org>
[not found] ` <bd688d7c-1588-43f3-49db-c90d1312fad8@gutov.dev>
[not found] ` <CALDnm5341n=_VtRH2JxsDEH=7uwdsaCQMSCOn+jzDpfnh1qm7A@mail.gmail.com>
[not found] ` <556e0fbb-215e-c11d-0e8b-73e97441abbb@gutov.dev>
[not found] ` <CALDnm52=KRVBn3Zse2DDC-SMHGot0mRpYUEZ7FH5vmAVH4Rimw@mail.gmail.com>
[not found] ` <e3408f6b-f050-a96d-c8c6-5f790cc90df4@gutov.dev>
2023-04-20 10:02 ` Eli Zaretskii
2023-04-20 10:31 ` João Távora
2023-04-20 11:49 ` Eli Zaretskii
2023-04-20 11:53 ` João Távora
2023-04-20 12:14 ` Eli Zaretskii
2023-04-20 13:39 ` Dmitry Gutov
2023-04-20 13:56 ` João Távora
2023-04-20 14:25 ` João Távora
2023-04-20 14:31 ` Dmitry Gutov
2023-04-20 14:40 ` João Távora
2023-04-21 0:22 ` Dmitry Gutov
2023-04-20 14:49 ` Eli Zaretskii
2023-04-20 15:03 ` João Távora
2023-04-20 14:51 ` Philip Kaludercic
2023-04-20 14:30 ` Dmitry Gutov
2023-04-20 14:25 ` Eli Zaretskii
2023-04-20 18:08 ` Robert Pluim
2023-04-20 18:24 ` Philip Kaludercic
2023-04-20 18:53 ` João Távora
2023-04-24 7:48 ` Robert Pluim
2023-04-24 8:57 ` João Távora
2023-04-24 9:38 ` Robert Pluim
2023-04-24 11:43 ` João Távora
2023-04-24 13:01 ` Robert Pluim
2023-04-24 13:08 ` Eli Zaretskii
2023-04-24 13:12 ` Robert Pluim
2023-04-24 20:36 ` Dmitry Gutov
2023-04-24 22:45 ` João Távora
2023-04-21 0:50 ` Dmitry Gutov
2023-04-21 6:37 ` Eli Zaretskii
2023-04-21 10:19 ` Dmitry Gutov
2023-04-21 11:05 ` Eli Zaretskii
2023-04-21 23:12 ` Dmitry Gutov
2023-04-22 0:57 ` Dmitry Gutov
2023-04-22 8:33 ` Eli Zaretskii
2023-04-22 10:30 ` Dmitry Gutov
2023-04-22 11:11 ` Eli Zaretskii
2023-04-22 11:24 ` Dmitry Gutov
2023-04-22 11:29 ` Dmitry Gutov
2023-04-22 12:01 ` Eli Zaretskii
2023-04-22 12:00 ` Eli Zaretskii [this message]
2023-04-22 12:14 ` Dmitry Gutov
2023-04-22 12:24 ` Eli Zaretskii
2023-04-22 23:46 ` Dmitry Gutov
2023-04-23 6:39 ` Eli Zaretskii
2023-04-23 11:58 ` Dmitry Gutov
2023-04-23 13:02 ` Eli Zaretskii
2023-04-23 13:11 ` Dmitry Gutov
2023-04-23 14:24 ` Eli Zaretskii
2023-04-23 21:53 ` Dmitry Gutov
2023-04-24 11:58 ` Eli Zaretskii
2023-04-24 23:45 ` Dmitry Gutov
2023-04-25 7:47 ` Eli Zaretskii
2023-04-25 12:08 ` Dmitry Gutov
2023-04-25 12:12 ` João Távora
2023-04-25 12:43 ` Eli Zaretskii
2023-04-25 18:35 ` Dmitry Gutov
2023-04-26 23:05 ` Dmitry Gutov
2023-04-27 5:41 ` Eli Zaretskii
2023-04-27 9:00 ` Dmitry Gutov
2023-04-27 10:44 ` Eli Zaretskii
2023-04-27 23:51 ` Dmitry Gutov
2023-04-28 5:19 ` Eli Zaretskii
2023-05-04 23:58 ` Dmitry Gutov
2023-05-05 5:04 ` Eli Zaretskii
2023-05-05 5:41 ` Philip Kaludercic
2023-05-05 13:58 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-05 14:05 ` Eli Zaretskii
2023-05-06 1:02 ` Dmitry Gutov
2023-04-23 13:05 ` Philip Kaludercic
2023-04-23 13:09 ` Dmitry Gutov
2023-04-22 0:57 ` João Távora
2023-04-22 11:38 ` Dmitry Gutov
2023-04-22 12:12 ` João Távora
2023-04-22 8:26 ` Eli Zaretskii
2023-04-22 10:48 ` Dmitry Gutov
2023-04-22 11:20 ` Eli Zaretskii
2023-04-14 13:40 ` Eli Zaretskii
2023-04-14 16:04 ` Dmitry Gutov
2023-04-14 17:43 ` Eli Zaretskii
2023-04-14 17:47 ` Dmitry Gutov
2023-04-14 17:59 ` Eli Zaretskii
2023-04-22 23:37 ` Dmitry Gutov
2023-04-23 13:02 ` Philip Kaludercic
2023-04-23 20:56 ` Dmitry Gutov
2023-04-25 12:24 ` Philip Kaludercic
2023-05-01 2:00 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-13 16:59 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-13 15:14 ` Philip Kaludercic
2023-04-13 15:59 ` Eli Zaretskii
2023-04-13 16:13 ` Dmitry Gutov
2023-04-13 19:14 ` Philip Kaludercic
2023-04-14 10:56 ` Eli Zaretskii
2023-04-14 16:40 ` Philip Kaludercic
2023-04-15 8:37 ` Eli Zaretskii
2023-04-15 10:41 ` Philip Kaludercic
2023-04-15 10:56 ` Eli Zaretskii
2023-04-15 11:37 ` Philip Kaludercic
2023-04-15 11:43 ` Eli Zaretskii
2023-04-15 13:21 ` Philip Kaludercic
2023-04-15 13:51 ` Eli Zaretskii
2023-04-15 17:14 ` Philip Kaludercic
2023-04-15 17:37 ` Eli Zaretskii
2023-04-15 18:19 ` Philip Kaludercic
2023-04-15 18:37 ` Eli Zaretskii
2023-04-16 13:45 ` Philip Kaludercic
2023-04-16 15:12 ` Eli Zaretskii
2023-04-16 10:44 ` João Távora
2023-04-16 14:23 ` Kévin Le Gouguec
2023-04-12 20:10 ` Philip Kaludercic
2023-04-13 5:49 ` Eli Zaretskii
2023-04-12 15:49 ` Dmitry Gutov
2023-04-12 15:59 ` Eli Zaretskii
2023-04-12 16:29 ` João Távora
2023-04-12 20:50 ` Dmitry Gutov
2023-04-12 15:45 ` Dmitry Gutov
2023-04-11 18:54 ` Eli Zaretskii
2023-04-11 20:28 ` João Távora
2023-04-12 5:51 ` Eli Zaretskii
2023-04-12 9:18 ` João Távora
2023-04-12 9:53 ` Eli Zaretskii
2023-04-12 12:37 ` João Távora
2023-04-12 13:20 ` Philip Kaludercic
2023-04-12 16:54 ` Eli Zaretskii
2023-04-11 19:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-11 20:05 ` João Távora
2023-04-11 21:36 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-12 7:34 ` Philip Kaludercic
2023-04-12 5:44 ` Eli Zaretskii
2023-04-12 7:44 ` Philip Kaludercic
2023-04-12 8:10 ` Eli Zaretskii
2023-04-12 14:14 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-11 21:14 ` Dmitry Gutov
2023-04-12 9:34 ` João Távora
2023-04-12 15:38 ` Dmitry Gutov
2023-04-08 7:10 ` Eli Zaretskii
2023-04-08 9:09 ` João Távora
2023-04-08 14:51 ` Ihor Radchenko
2023-04-08 15:23 ` João Távora
2023-04-08 15:31 ` Ihor Radchenko
2023-04-08 18:10 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83edoc1602.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=62720@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=joaotavora@gmail.com \
--cc=jporterbugs@gmail.com \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).