bug#49953: 28.0.50; tmm is broken on compiled menus

bug#49953: 28.0.50; tmm is broken on compiled menus

[Juri Linkov]

0. emacs -Q
1. Eval: (tmm-prompt (mouse-buffer-menu-keymap))
2. Select a menu item with the mouse click
   from the *Completions* buffer
3. It fails with this backtrace:

Debugger entered--Lisp error: (error "Empty menu reached")
  error("Empty menu reached")
  tmm-prompt((keymap "Select Buffer" [("*scratch* * " . #f(compiled-function () (interactive nil) #<bytecode...
  tmm-prompt((keymap (Select\ Buffer "Select Buffer" keymap ...
  (progn (tmm-prompt (mouse-buffer-menu-keymap)))
  eval((progn (tmm-prompt (mouse-buffer-menu-keymap))) t)
  elisp--eval-last-sexp((4))
  eval-last-sexp((4))
  funcall-interactively(eval-last-sexp (4))
  call-interactively(eval-last-sexp nil nil)
  command-execute(eval-last-sexp)

This regression began to occur after merging native-compilation.
It seems the problem is that tmm-get-keymap does very strange things:

	(cond ((if (listp elt)
		   (or (keymapp elt) (eq (car elt) 'lambda))
		 (and (symbolp elt) (fboundp elt)))

I don't know why it checks for 'lambda' and 'symbolp',
but such checks fail on a compiled function.

bug#49953: 28.0.50; tmm is broken on compiled menus

[Lars Ingebrigtsen]

Juri Linkov <juri@linkov.net> writes:

> This regression began to occur after merging native-compilation.
> It seems the problem is that tmm-get-keymap does very strange things:
>
> 	(cond ((if (listp elt)
> 		   (or (keymapp elt) (eq (car elt) 'lambda))
> 		 (and (symbolp elt) (fboundp elt)))
>
> I don't know why it checks for 'lambda' and 'symbolp',
> but such checks fail on a compiled function.

Yeah, or why the listp at all...  I think the correct test in all these
cases are (or (keymapp elt) (functionp elt))?  So I've now done that on
the trunk, and that seems to make things work.  But there may be
something subtle here, so I guess we'll see...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#49953: 28.0.50; tmm is broken on compiled menus

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Mon, 09 Aug 2021 15:20:58 +0200
> Cc: 49953@debbugs.gnu.org
> 
> Juri Linkov <juri@linkov.net> writes:
> 
> > This regression began to occur after merging native-compilation.
> > It seems the problem is that tmm-get-keymap does very strange things:
> >
> > 	(cond ((if (listp elt)
> > 		   (or (keymapp elt) (eq (car elt) 'lambda))
> > 		 (and (symbolp elt) (fboundp elt)))
> >
> > I don't know why it checks for 'lambda' and 'symbolp',
> > but such checks fail on a compiled function.
> 
> Yeah, or why the listp at all...  I think the correct test in all these
> cases are (or (keymapp elt) (functionp elt))?  So I've now done that on
> the trunk, and that seems to make things work.  But there may be
> something subtle here, so I guess we'll see...

I have a vague recollection that at least some of those are used, so I
brought Stefan on-board this discussion, in the hope that he could
show us the light.

bug#49953: 28.0.50; tmm is broken on compiled menus

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

>> > This regression began to occur after merging native-compilation.
>> > It seems the problem is that tmm-get-keymap does very strange things:
>> >
>> > 	(cond ((if (listp elt)
>> > 		   (or (keymapp elt) (eq (car elt) 'lambda))
>> > 		 (and (symbolp elt) (fboundp elt)))
>> >
>> > I don't know why it checks for 'lambda' and 'symbolp',
>> > but such checks fail on a compiled function.
>> 
>> Yeah, or why the listp at all...  I think the correct test in all these
>> cases are (or (keymapp elt) (functionp elt))?  So I've now done that on
>> the trunk, and that seems to make things work.  But there may be
>> something subtle here, so I guess we'll see...
>
> I have a vague recollection that at least some of those are used, so I
> brought Stefan on-board this discussion, in the hope that he could
> show us the light.

Sorry, my lightbulb is currently out, but I agree that the above test
seems to want to do (or (keymapp elt) (functionp elt)) just in
a clumsy way.


        Stefan