From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#49953: 28.0.50; tmm is broken on compiled menus Date: Mon, 09 Aug 2021 14:23:09 -0400 Message-ID: References: <87im0fhz1f.fsf@mail.linkov.net> <877dgu4uv9.fsf@gnus.org> <83czqmh7dr.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40495"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 49953@debbugs.gnu.org, Lars Ingebrigtsen , juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 09 20:24:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mD9wY-000AGK-Mz for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 Aug 2021 20:24:10 +0200 Original-Received: from localhost ([::1]:55322 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mD9wW-0002RX-M7 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 Aug 2021 14:24:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mD9wQ-0002RJ-BW for bug-gnu-emacs@gnu.org; Mon, 09 Aug 2021 14:24:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46202) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mD9wQ-0003oE-5H for bug-gnu-emacs@gnu.org; Mon, 09 Aug 2021 14:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mD9wP-0003Al-W6 for bug-gnu-emacs@gnu.org; Mon, 09 Aug 2021 14:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Aug 2021 18:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49953 X-GNU-PR-Package: emacs Original-Received: via spool by 49953-submit@debbugs.gnu.org id=B49953.162853340112144 (code B ref 49953); Mon, 09 Aug 2021 18:24:01 +0000 Original-Received: (at 49953) by debbugs.gnu.org; 9 Aug 2021 18:23:21 +0000 Original-Received: from localhost ([127.0.0.1]:57748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mD9vl-00039o-Jp for submit@debbugs.gnu.org; Mon, 09 Aug 2021 14:23:21 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:60734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mD9vh-00039X-UD for 49953@debbugs.gnu.org; Mon, 09 Aug 2021 14:23:19 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 60A628090A; Mon, 9 Aug 2021 14:23:12 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1FE3F80547; Mon, 9 Aug 2021 14:23:11 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1628533391; bh=HOCDPJAkrPg39cELFPZYMEf2Jx2UiWNM99JBh5bCyN0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=TucBJtRUHoIXqiPdjDdpLPv2VWnVtKKwhuC+EOzqi06TQ1VnWANbECXg8uVxX1nA9 116YQPDmlV+7ANiZYLG53z38MMwTtvm7/QjdTvLe4hIjynOBWn0JavwqHRDIRzrukD 1CJ9Cze3qooPqXpVRM8YO7alHY/SBGTZVZGhYKlpTWW5NEsVrLB/BsTqYq833BG729 wfLEWk5zNrmdO/2j5bTg28udV4S7F4ic2EmfYpL18ZH6/f3ChfH45nDVB49qydFaQq AnvyYWaiZMuOxvkcqquXYjg/n9kgU04kcpeWXDCACgkUyp1Y73tdBjPaqlFeQYRBoE j/smVEoguk6Pg== Original-Received: from alfajor (104-222-120-40.cpe.teksavvy.com [104.222.120.40]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 85B69120454; Mon, 9 Aug 2021 14:23:10 -0400 (EDT) In-Reply-To: <83czqmh7dr.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 09 Aug 2021 20:09:52 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211459 Archived-At: >> > This regression began to occur after merging native-compilation. >> > It seems the problem is that tmm-get-keymap does very strange things: >> > >> > (cond ((if (listp elt) >> > (or (keymapp elt) (eq (car elt) 'lambda)) >> > (and (symbolp elt) (fboundp elt))) >> > >> > I don't know why it checks for 'lambda' and 'symbolp', >> > but such checks fail on a compiled function. >> >> Yeah, or why the listp at all... I think the correct test in all these >> cases are (or (keymapp elt) (functionp elt))? So I've now done that on >> the trunk, and that seems to make things work. But there may be >> something subtle here, so I guess we'll see... > > I have a vague recollection that at least some of those are used, so I > brought Stefan on-board this discussion, in the hope that he could > show us the light. Sorry, my lightbulb is currently out, but I agree that the above test seems to want to do (or (keymapp elt) (functionp elt)) just in a clumsy way. Stefan