From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#49953: 28.0.50; tmm is broken on compiled menus Date: Mon, 09 Aug 2021 20:09:52 +0300 Message-ID: <83czqmh7dr.fsf@gnu.org> References: <87im0fhz1f.fsf@mail.linkov.net> <877dgu4uv9.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33947"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49953@debbugs.gnu.org, juri@linkov.net To: Lars Ingebrigtsen , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 09 19:10:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mD8mx-0008f7-Tk for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 Aug 2021 19:10:11 +0200 Original-Received: from localhost ([::1]:48208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mD8mw-0008Gi-Q8 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 Aug 2021 13:10:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mD8mo-0008GX-Nz for bug-gnu-emacs@gnu.org; Mon, 09 Aug 2021 13:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46122) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mD8mo-00021b-G5 for bug-gnu-emacs@gnu.org; Mon, 09 Aug 2021 13:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mD8mo-0001Ka-9D for bug-gnu-emacs@gnu.org; Mon, 09 Aug 2021 13:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Aug 2021 17:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49953 X-GNU-PR-Package: emacs Original-Received: via spool by 49953-submit@debbugs.gnu.org id=B49953.16285289955098 (code B ref 49953); Mon, 09 Aug 2021 17:10:02 +0000 Original-Received: (at 49953) by debbugs.gnu.org; 9 Aug 2021 17:09:55 +0000 Original-Received: from localhost ([127.0.0.1]:57668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mD8mg-0001KA-Qm for submit@debbugs.gnu.org; Mon, 09 Aug 2021 13:09:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mD8md-0001Jw-Iq for 49953@debbugs.gnu.org; Mon, 09 Aug 2021 13:09:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49514) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mD8mX-0001rA-IK; Mon, 09 Aug 2021 13:09:45 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4754 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mD8mW-00031X-MX; Mon, 09 Aug 2021 13:09:45 -0400 In-Reply-To: <877dgu4uv9.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 09 Aug 2021 15:20:58 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211456 Archived-At: > From: Lars Ingebrigtsen > Date: Mon, 09 Aug 2021 15:20:58 +0200 > Cc: 49953@debbugs.gnu.org > > Juri Linkov writes: > > > This regression began to occur after merging native-compilation. > > It seems the problem is that tmm-get-keymap does very strange things: > > > > (cond ((if (listp elt) > > (or (keymapp elt) (eq (car elt) 'lambda)) > > (and (symbolp elt) (fboundp elt))) > > > > I don't know why it checks for 'lambda' and 'symbolp', > > but such checks fail on a compiled function. > > Yeah, or why the listp at all... I think the correct test in all these > cases are (or (keymapp elt) (functionp elt))? So I've now done that on > the trunk, and that seems to make things work. But there may be > something subtle here, so I guess we'll see... I have a vague recollection that at least some of those are used, so I brought Stefan on-board this discussion, in the hope that he could show us the light.