unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Philip Kaludercic <philipk@posteo.net>
Cc: contovob@tcd.ie, 63260@debbugs.gnu.org, rpluim@gmail.com
Subject: bug#63260: 29.0.90; Regression installing/activating packages without autoloads
Date: Sun, 07 May 2023 16:21:01 +0300	[thread overview]
Message-ID: <83cz3ce0qq.fsf@gnu.org> (raw)
In-Reply-To: <87jzxkcmk0.fsf@posteo.net> (message from Philip Kaludercic on Sun, 07 May 2023 13:12:47 +0000)

> From: Philip Kaludercic <philipk@posteo.net>
> Cc: contovob@tcd.ie,  63260@debbugs.gnu.org,  rpluim@gmail.com
> Date: Sun, 07 May 2023 13:12:47 +0000
> 
> One hack might just be to check if `loaddefs-generate' has generated
> anything at all or not, and if that is not the case to do so manually in
> package.el.  The reason this doesn't seem nice, is that we'd have to
> make the fact that `loaddefs-generate' does not generate a OUTPUT-FILE
> if there is no file with autoloads explicit, and finding a justification
> for that is difficult.  Alternatively, this could be done inside of
> `loaddefs-generate'?  Something like

Assuming it solves the issue and doesn't break anything, the latter
sounds good to me, better than the alternatives.

> +    ;; HACK: If no file with autoloads were found, but EXTRA-DATA was
> +    ;; passed, we still want to generate a file.

The comment says "EXTRA-DATA was passed", but this added snipped will
also run if EXTRA-DATA was NOT passed, but the OUTPUT-FILE doesn't
exist, right?

And I would explain in the comment the real-life situations where this
is needed, and why, rather than just explaining in English what the
code does.

Thanks.





  reply	other threads:[~2023-05-07 13:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-04 10:15 bug#63260: 29.0.90; Regression installing/activating packages without autoloads Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-04 15:15 ` Robert Pluim
2023-05-04 16:28   ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-05  6:36     ` Robert Pluim
2023-05-06  9:01       ` Eli Zaretskii
2023-05-06 12:51         ` Robert Pluim
2023-05-06 13:12         ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-06 13:28           ` Eli Zaretskii
2023-05-07 10:59             ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-06 13:10       ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-06 13:23         ` Eli Zaretskii
2023-05-07  9:46           ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-07 10:50             ` Eli Zaretskii
2023-05-07 12:39               ` Philip Kaludercic
2023-05-07 12:54                 ` Eli Zaretskii
2023-05-07 13:12                   ` Philip Kaludercic
2023-05-07 13:21                     ` Eli Zaretskii [this message]
2023-05-07 19:37                       ` Philip Kaludercic
2023-05-08 11:16                         ` Eli Zaretskii
2023-05-08 13:15                           ` Robert Pluim
2023-05-08 13:18                             ` Eli Zaretskii
2023-05-08 13:23                               ` Robert Pluim
2023-05-10 13:12                           ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-10 14:22                             ` Eli Zaretskii
2023-05-12  7:43                               ` Philip Kaludercic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83cz3ce0qq.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=63260@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=philipk@posteo.net \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).