From: Basil Contovounesios via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 63260@debbugs.gnu.org, Robert Pluim <rpluim@gmail.com>,
philipk@posteo.net
Subject: bug#63260: 29.0.90; Regression installing/activating packages without autoloads
Date: Sat, 06 May 2023 15:12:31 +0200 [thread overview]
Message-ID: <87wn1lsiww.fsf@tcd.ie> (raw)
In-Reply-To: <83bkixhm0c.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 May 2023 05:00:17 -0400")
Eli Zaretskii [2023-05-06 05:00 -0400] wrote:
>> Cc: 63260@debbugs.gnu.org, Philip Kaludercic <philipk@posteo.net>
>> From: Robert Pluim <rpluim@gmail.com>
>> Date: Fri, 05 May 2023 08:36:51 +0200
>>
>> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
>> index 0919ce34448..4b488281b78 100644
>> --- a/lisp/emacs-lisp/package.el
>> +++ b/lisp/emacs-lisp/package.el
>> @@ -4491,11 +4491,11 @@ package-quickstart-refresh
>> (insert ";;; Quickstart file to activate all packages at startup -*- lexical-binding:t -*-\n")
>> (insert ";; ¡¡ This file is autogenerated by `package-quickstart-refresh', DO NOT EDIT !!\n\n")
>> (dolist (pkg package--quickstart-pkgs)
>> - (let* ((file
>> - ;; Prefer uncompiled files (and don't accept .so files).
>> - (let ((load-suffixes '(".el" ".elc")))
>> - (locate-library (package--autoloads-file-name pkg))))
>> - (pfile (prin1-to-string file)))
>> + (when-let* ((file
>> + ;; Prefer uncompiled files (and don't accept .so files).
>> + (let ((load-suffixes '(".el" ".elc")))
>> + (locate-library (package--autoloads-file-name pkg))))
>> + (pfile (prin1-to-string file)))
>> (insert "(let ((load-true-file-name " pfile ")\
>> \(load-file-name " pfile "))\n")
>> (insert-file-contents file)
>
> Philip, Basil: is the above okay with you? I'd like this issue
> resolved before making the next pretest of Emacs 29.1.
As I said in my other message, AFAICT this fixes a symptom specific to
package-quickstart of the more general autoload file problem
reintroduced by dd21003878d.
Thanks,
--
Basil
next prev parent reply other threads:[~2023-05-06 13:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 10:15 bug#63260: 29.0.90; Regression installing/activating packages without autoloads Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-04 15:15 ` Robert Pluim
2023-05-04 16:28 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-05 6:36 ` Robert Pluim
2023-05-06 9:01 ` Eli Zaretskii
2023-05-06 12:51 ` Robert Pluim
2023-05-06 13:12 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-05-06 13:28 ` Eli Zaretskii
2023-05-07 10:59 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-06 13:10 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-06 13:23 ` Eli Zaretskii
2023-05-07 9:46 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-07 10:50 ` Eli Zaretskii
2023-05-07 12:39 ` Philip Kaludercic
2023-05-07 12:54 ` Eli Zaretskii
2023-05-07 13:12 ` Philip Kaludercic
2023-05-07 13:21 ` Eli Zaretskii
2023-05-07 19:37 ` Philip Kaludercic
2023-05-08 11:16 ` Eli Zaretskii
2023-05-08 13:15 ` Robert Pluim
2023-05-08 13:18 ` Eli Zaretskii
2023-05-08 13:23 ` Robert Pluim
2023-05-10 13:12 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-10 14:22 ` Eli Zaretskii
2023-05-12 7:43 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn1lsiww.fsf@tcd.ie \
--to=bug-gnu-emacs@gnu.org \
--cc=63260@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=eliz@gnu.org \
--cc=philipk@posteo.net \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).