From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63260: 29.0.90; Regression installing/activating packages without autoloads Date: Sun, 07 May 2023 16:21:01 +0300 Message-ID: <83cz3ce0qq.fsf@gnu.org> References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> <87lei3nv24.fsf@gmail.com> <87a5yhtxkw.fsf@tcd.ie> <83sfc9fva8.fsf@gnu.org> <87mt2go4ne.fsf@tcd.ie> <83pm7ce7p2.fsf@gnu.org> <87y1m0co2z.fsf@posteo.net> <83fs88e1yz.fsf@gnu.org> <87jzxkcmk0.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24294"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, 63260@debbugs.gnu.org, rpluim@gmail.com To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 07 15:21:37 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pveKW-00066m-Ru for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 May 2023 15:21:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pveKE-0000Ei-2Q; Sun, 07 May 2023 09:21:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pveK8-0000DH-HZ for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 09:21:12 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pveJy-0007Uy-DS for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 09:21:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pveJx-0004v3-SK for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 09:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 May 2023 13:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63260 X-GNU-PR-Package: emacs Original-Received: via spool by 63260-submit@debbugs.gnu.org id=B63260.168346561218798 (code B ref 63260); Sun, 07 May 2023 13:21:01 +0000 Original-Received: (at 63260) by debbugs.gnu.org; 7 May 2023 13:20:12 +0000 Original-Received: from localhost ([127.0.0.1]:36690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pveJ9-0004t8-VE for submit@debbugs.gnu.org; Sun, 07 May 2023 09:20:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pveJ8-0004sv-GI for 63260@debbugs.gnu.org; Sun, 07 May 2023 09:20:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pveJ2-0007Nu-5q; Sun, 07 May 2023 09:20:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ro9OI2IswZsobd3jUCVyIxrYyhMyynlapECuUIPgrFU=; b=sItPDreBpQSP h02GbxVUaUEKWS+NzuxEe16/EwpzxGKrFbSzaqAfbrEu0Lfpj/pJsxpbv0BLE6LAUz9SHKUv3oK2N URLGF9LTb4Ry4bPb4Xl7+6JkIgT/wPK31Sg4bS5oD63A/IKwqn/hm+E6tfs9XSbpukvHNVkkOEaiS C1daetr38zwty/TEWTyVJS+k8dlQYeqxIFDXGHyfnwLKwdGX3Nf7h6Aje6PcniqhiIkfbJsQ0WJTy JYVx+9jHDQBUC471ht5erQ76BQ0nEzNSOflVl0oCdCTRWZJ+4n4g5zlxMjZaInbY92nGfThH/tKf6 HMHXQ+BcAMnmlIfTi5pOow==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pveJ0-0006Kg-Vk; Sun, 07 May 2023 09:20:03 -0400 In-Reply-To: <87jzxkcmk0.fsf@posteo.net> (message from Philip Kaludercic on Sun, 07 May 2023 13:12:47 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261259 Archived-At: > From: Philip Kaludercic > Cc: contovob@tcd.ie, 63260@debbugs.gnu.org, rpluim@gmail.com > Date: Sun, 07 May 2023 13:12:47 +0000 > > One hack might just be to check if `loaddefs-generate' has generated > anything at all or not, and if that is not the case to do so manually in > package.el. The reason this doesn't seem nice, is that we'd have to > make the fact that `loaddefs-generate' does not generate a OUTPUT-FILE > if there is no file with autoloads explicit, and finding a justification > for that is difficult. Alternatively, this could be done inside of > `loaddefs-generate'? Something like Assuming it solves the issue and doesn't break anything, the latter sounds good to me, better than the alternatives. > + ;; HACK: If no file with autoloads were found, but EXTRA-DATA was > + ;; passed, we still want to generate a file. The comment says "EXTRA-DATA was passed", but this added snipped will also run if EXTRA-DATA was NOT passed, but the OUTPUT-FILE doesn't exist, right? And I would explain in the comment the real-life situations where this is needed, and why, rather than just explaining in English what the code does. Thanks.