From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64452: [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log* Date: Thu, 06 Jul 2023 11:52:02 +0300 Message-ID: <83bkgpifrh.fsf@gnu.org> References: <87sfa44ixh.fsf@gmail.com> <83zg4ckki0.fsf@gnu.org> <87bkgr48qy.fsf@gmail.com> <83lefuk3b7.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16034"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64452-done@debbugs.gnu.org, iarchivedmywholelife@gmail.com, monnier@iro.umontreal.ca To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 06 10:53:36 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHKk1-0003si-3k for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Jul 2023 10:53:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qHKjn-0004Tc-Vc; Thu, 06 Jul 2023 04:53:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHKjY-0004RD-4n for bug-gnu-emacs@gnu.org; Thu, 06 Jul 2023 04:53:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qHKjW-0008Hv-Ui for bug-gnu-emacs@gnu.org; Thu, 06 Jul 2023 04:53:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qHKjW-0006dW-Bt for bug-gnu-emacs@gnu.org; Thu, 06 Jul 2023 04:53:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Jul 2023 08:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 64452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 64452@debbugs.gnu.org, eliz@gnu.org, iarchivedmywholelife@gmail.com Original-Received: via spool by 64452-done@debbugs.gnu.org id=D64452.168863353225449 (code D ref 64452); Thu, 06 Jul 2023 08:53:02 +0000 Original-Received: (at 64452-done) by debbugs.gnu.org; 6 Jul 2023 08:52:12 +0000 Original-Received: from localhost ([127.0.0.1]:39549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHKih-0006cO-Jo for submit@debbugs.gnu.org; Thu, 06 Jul 2023 04:52:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHKif-0006cB-JQ for 64452-done@debbugs.gnu.org; Thu, 06 Jul 2023 04:52:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHKiZ-00087f-RO; Thu, 06 Jul 2023 04:52:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pDx5c6oX6TcwH5RO/HdTi0uSeTve7EYoOv/Dn8ie0rw=; b=D3miC9UemqFW Yk9gTx8eSllhSIllmumyjRW1XwXKK1OR7wwMiWMn9J9VcgecMbNNC4Vz3l7QoF9kTiTYhwAjczefh lljfljt6Du2nHV+dhmh55SFdWLAslaxMhkv22qnWK7nJJWIv7qL90S+s537VbzTNOmGjspoMZ2YFP Rj8ZYtnMBPGErRzl0PoBx7ttYqMNvtkflE2svWmX8UHyOy5BaXkRQgIpsCyYzwohMGo3fOIynRnZH 0WhNylEi/l5blbHbk1Q87dMi1sf9VEWXEiWOZSCWvlDZWP1xJnc8xMn9B150+gozXMBqfst/zqjBJ Y96EiDz7NhZApINQgeJ1XA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHKiZ-0005se-At; Thu, 06 Jul 2023 04:52:03 -0400 In-Reply-To: (message from Andrea Corallo on Wed, 05 Jul 2023 10:47:47 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264669 Archived-At: > From: Andrea Corallo > Cc: No Wayman , monnier@iro.umontreal.ca, > 64452@debbugs.gnu.org > Date: Wed, 05 Jul 2023 10:47:47 -0400 > > Eli Zaretskii writes: > > >> From: No Wayman > >> Cc: Andrea Corallo , Stefan Monnier > >> , 64452@debbugs.gnu.org > >> Date: Tue, 04 Jul 2023 18:21:00 -0400 > >> > >> Eli Zaretskii writes: > >> > >> > Thanks, but why not elisp-compile-mode, like we do in > >> > *Compile-log* > >> > buffers for byte compilation? > >> > >> Works for me. Revision attached. > >> > >> diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el > >> index 22fb08e4688..5f42d10407f 100644 > >> --- a/lisp/emacs-lisp/comp.el > >> +++ b/lisp/emacs-lisp/comp.el > >> @@ -1133,7 +1133,8 @@ comp-log-to-buffer > >> (log-buffer > >> (or (get-buffer comp-log-buffer-name) > >> (with-current-buffer (get-buffer-create comp-log-buffer-name) > >> - (setf buffer-read-only t) > >> + (unless (derived-mode-p 'emacs-lisp-compilation-mode) > >> + (emacs-lisp-compilation-mode)) > > > > bytecomp.el uses > > > > (unless (derived-mode-p 'compilation-mode) > > (emacs-lisp-compilation-mode)) > > > > Isn't that better? > > > > Also, do we really need to do this twice in comp-run-async-workers? > > > > Andrea, any comments? > > No, haven't tried it but it LGTM form here. Thanks, installed on the master branch, and closing the bug.