From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66470: 29.1; Provide Urdu input method Date: Sat, 04 Nov 2023 10:39:05 +0200 Message-ID: <83bkc96hg6.fsf@gnu.org> References: <87pm1lm23l.fsf@zohomail.eu> <87lec9m12g.fsf@zohomail.eu> <837cnpshz2.fsf@gnu.org> <877cnp1ojf.fsf@zohomail.eu> <83zg0lqxtq.fsf@gnu.org> <8734yd1mfm.fsf@zohomail.eu> <83sf6dqt33.fsf@gnu.org> <87zg0bye19.fsf@zohomail.eu> <83leblbq9e.fsf@gnu.org> <87v8apqtff.fsf@zohomail.eu> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33664"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66470@debbugs.gnu.org To: Rahguzar Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 04 09:39:54 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qzCC9-0008ZN-0e for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Nov 2023 09:39:53 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qzCBj-0007Kx-IV; Sat, 04 Nov 2023 04:39:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzCBi-0007Kj-D1 for bug-gnu-emacs@gnu.org; Sat, 04 Nov 2023 04:39:26 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qzCBi-0007RC-4Y for bug-gnu-emacs@gnu.org; Sat, 04 Nov 2023 04:39:26 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qzCCH-0007x7-PJ for bug-gnu-emacs@gnu.org; Sat, 04 Nov 2023 04:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Nov 2023 08:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66470 X-GNU-PR-Package: emacs Original-Received: via spool by 66470-submit@debbugs.gnu.org id=B66470.169908719330549 (code B ref 66470); Sat, 04 Nov 2023 08:40:01 +0000 Original-Received: (at 66470) by debbugs.gnu.org; 4 Nov 2023 08:39:53 +0000 Original-Received: from localhost ([127.0.0.1]:60564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzCC9-0007we-2S for submit@debbugs.gnu.org; Sat, 04 Nov 2023 04:39:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzCC7-0007wQ-Nc for 66470@debbugs.gnu.org; Sat, 04 Nov 2023 04:39:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzCBQ-0007CR-1x; Sat, 04 Nov 2023 04:39:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VquOf732kRkzzOPMcx1SUMliJ5doNsE6iDyYiNmjPD4=; b=ca2vbZ9sRobm ZA3UXh/gru8+PWjONNcXPzZRer/uF7naSn6CIpg1ivTuibo3NDoOfTicYj2/tKWl9+TSVFGRVv9l8 gQNeeEUSvUbPwzGpcYlop5Cr4VgyodFIX4f+3qBWxnRS34q7gCHMWdlsbFPQHqY4OdiTlE317WUrH +BIbb0mtOqRu3sFCbeymy9xCk65Harx2lsM4kSEUwBzQGzed03ork7i23wxjUgei9YSyNWPYiceFl b10/azkx1bzSmFBgPbffldso3iVrICTouw1ObMw55DXMwSUaFcbIp3ZdxIGhTirsbrDcgN0yiDcAh 27S7LxM8IqzGQnLFC9d3Jw==; In-Reply-To: <87v8apqtff.fsf@zohomail.eu> (message from Rahguzar on Sun, 29 Oct 2023 17:27:38 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273756 Archived-At: > From: Rahguzar > Cc: 66470@debbugs.gnu.org > Date: Sun, 29 Oct 2023 17:27:38 +0100 > > Thanks for the review. I have made the changes you asked for, please > let me know of other changes need. Below. > Subject: [PATCH] Input methods for Urdu, Pashto and Sindhi > > * lisp/leim/quail/pakistan.el (quail): > ("urdu-keyboard"): new input method > ("urdu-phonetic-keyboard"): new input method > ("urdu-custom"): new input method > ("sindhi-keyboard"): new input method > ("pashto-keyboard"): new input method These should be brought together, and the description should start with a capitalized letter and end with a period. Like this: * lisp/leim/quail/pakistan.el ("urdu-keyboard") ("urdu-phonetic-keyboard", "urdu-custom", "sindhi-keyboard") ("pashto-keyboard"): New input methods > ; (pakistan--define-quail-rules): helper function > ; (pakistan--make-setter): helper function > ; (pakistan--regenerate-translations): helper function > ; (pakistan--set-prefixes): helper function > ; (pakistan--set-numeral-translations): Why are there semi-colons here? > (pakistan-urdu-input): new customization group > (pakistan-urdu-prefixes): new custom variable > (pakistan-urdu-translations): new custom variable > (pakistan-urdu-diacritics-and-other-symbols): new custom var > (pakistan-urdu-poetic-symbols): new custom var > (pakistan-urdu-religious-symbols): new custom var > (pakistan-extra-balochi-brahui-translations): new custom var > (pakistan-extra-pashto-translations): new custom var > (pakistan-extra-sindhi-translations): new custom var > (pakistan-extra-saraiki-hindko-translations): new custom var > (pakistan-urdu-use-roman-digits): new custom var > (pakistan): new package This should again be a single entry about multiple variables, since they all share the same description: "New custom variable". While compiling this, I get byte-compiler warnings: In pakistan--define-quail-rules: leim/quail/pakistan.el:199:41: Warning: reference to free variable `pakistan-urdu-prefixes' In pakistan--regenerate-translations: leim/quail/pakistan.el:215:33: Warning: reference to free variable `pakistan-urdu-translations' leim/quail/pakistan.el:217:4: Warning: reference to free variable `pakistan-urdu-diacritics-and-other-symbols' leim/quail/pakistan.el:218:33: Warning: reference to free variable `pakistan-urdu-poetic-symbols' leim/quail/pakistan.el:219:33: Warning: reference to free variable `pakistan-urdu-religious-symbols' leim/quail/pakistan.el:220:33: Warning: reference to free variable `pakistan-extra-balochi-translations' leim/quail/pakistan.el:221:33: Warning: reference to free variable `pakistan-extra-pashto-translations' leim/quail/pakistan.el:222:33: Warning: reference to free variable `pakistan-extra-saraiki-translations' leim/quail/pakistan.el:223:33: Warning: reference to free variable `pakistan-extra-sindhi-translations'