From: Eli Zaretskii <eliz@gnu.org>
To: Felician Nemeth <felician.nemeth@gmail.com>
Cc: 57325@debbugs.gnu.org
Subject: bug#57325: 27.1; functions in ff-other-file-alist
Date: Tue, 30 Aug 2022 15:43:56 +0300 [thread overview]
Message-ID: <83a67lvr3n.fsf@gnu.org> (raw)
In-Reply-To: <87pmgiqftt.fsf@betli.tmit.bme.hu> (message from Felician Nemeth on Tue, 30 Aug 2022 10:46:22 +0200)
> From: Felician Nemeth <felician.nemeth@gmail.com>
> Cc: 57325@debbugs.gnu.org
> Date: Tue, 30 Aug 2022 10:46:22 +0200
>
> > If the returned list includes file names with leading directories,
> > find-file.el strips the leading directories and uses the basename to
> > match against.
>
> I think that not how it works.
Sorry, I misread the code. You are right.
But then I think we should replace this code in ff-get-file-name:
(setq file (concat dir "/" filename))
with
(setq file (expand-file-name filename dir))
and then the code will work with absolute file names as well, even if
the file is not already visited in a buffer. Right?
> Playing with the implementation, I think that these functions shouldn't
> return extensions. They should return file names.
You are right. I updated the doc string to say that.
next prev parent reply other threads:[~2022-08-30 12:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-21 18:34 bug#57325: 27.1; functions in ff-other-file-alist Felician Nemeth
2022-08-21 18:55 ` Eli Zaretskii
2022-08-21 19:37 ` Felician Nemeth
2022-08-22 11:44 ` Eli Zaretskii
2022-08-25 8:14 ` Eli Zaretskii
2022-08-29 11:57 ` Felician Nemeth
2022-08-29 14:04 ` Eli Zaretskii
2022-08-29 14:27 ` Felician Nemeth
2022-08-29 16:49 ` Eli Zaretskii
2022-08-30 8:46 ` Felician Nemeth
2022-08-30 12:43 ` Eli Zaretskii [this message]
2022-08-30 13:48 ` Felician Nemeth
2022-08-30 16:10 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a67lvr3n.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=57325@debbugs.gnu.org \
--cc=felician.nemeth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).