From: Felician Nemeth <felician.nemeth@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 57325@debbugs.gnu.org
Subject: bug#57325: 27.1; functions in ff-other-file-alist
Date: Sun, 21 Aug 2022 21:37:31 +0200 [thread overview]
Message-ID: <875yiljslg.fsf@betli.tmit.bme.hu> (raw)
In-Reply-To: <83h725bf4w.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 21 Aug 2022 21:55:27 +0300")
> Thanks, now fixed on the emacs-28 branch.
Thank you.
>> More importantly, if the associated value is a function, then there's no
>> way for the function to signal that it cannot find a related file.
> What would you have the package do instead when "the other" file is
> not found?
Most probably I just failed to understand that my-find-related-file
should not return nil and, as you say, it cannot meaningfully signal a
failure. If this is the case, this bug can be closed and I'm sorry for
the noise.
I got confused because if I remove the
(setq uniquify-buffer-name-style nil) line from bug.el, then
ff-find-related-file will open the parent directory of xref.el, which
feels correct. However, with that line setting
uniquify-buffer-name-style, ff-find-related-file selects /tmp/dir/1234,
which feels wrong because that buffer has nothing to do with xref.el.
In my case, a file can contain a link to another file (a .toml file to a
schema file). I wasn't sure what to do when the original file did not
contain a link. Maybe my-find-related-file should ask the user what to
do in this case, or just do a (user-error "There's no related file.").
Thanks again.
next prev parent reply other threads:[~2022-08-21 19:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-21 18:34 bug#57325: 27.1; functions in ff-other-file-alist Felician Nemeth
2022-08-21 18:55 ` Eli Zaretskii
2022-08-21 19:37 ` Felician Nemeth [this message]
2022-08-22 11:44 ` Eli Zaretskii
2022-08-25 8:14 ` Eli Zaretskii
2022-08-29 11:57 ` Felician Nemeth
2022-08-29 14:04 ` Eli Zaretskii
2022-08-29 14:27 ` Felician Nemeth
2022-08-29 16:49 ` Eli Zaretskii
2022-08-30 8:46 ` Felician Nemeth
2022-08-30 12:43 ` Eli Zaretskii
2022-08-30 13:48 ` Felician Nemeth
2022-08-30 16:10 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yiljslg.fsf@betli.tmit.bme.hu \
--to=felician.nemeth@gmail.com \
--cc=57325@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).