From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#57325: 27.1; functions in ff-other-file-alist Date: Tue, 30 Aug 2022 15:43:56 +0300 Message-ID: <83a67lvr3n.fsf@gnu.org> References: <87fshpjviu.fsf@betli.tmit.bme.hu> <83h725bf4w.fsf@gnu.org> <875yiljslg.fsf@betli.tmit.bme.hu> <837d30biz4.fsf@gnu.org> <831qt44u5f.fsf@gnu.org> <87czcjs1mv.fsf@betli.tmit.bme.hu> <83r10zw3gj.fsf@gnu.org> <87zgfnqg5a.fsf@betli.tmit.bme.hu> <83edwzvvtg.fsf@gnu.org> <87pmgiqftt.fsf@betli.tmit.bme.hu> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13914"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57325@debbugs.gnu.org To: Felician Nemeth Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 30 14:44:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oT0bL-0003Up-LZ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Aug 2022 14:44:19 +0200 Original-Received: from localhost ([::1]:36596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oT0bK-0007D9-Lx for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Aug 2022 08:44:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54032) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT0b4-0007CI-TN for bug-gnu-emacs@gnu.org; Tue, 30 Aug 2022 08:44:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45314) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oT0b4-0004iM-Jm for bug-gnu-emacs@gnu.org; Tue, 30 Aug 2022 08:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oT0b4-00037P-FT for bug-gnu-emacs@gnu.org; Tue, 30 Aug 2022 08:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Aug 2022 12:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57325 X-GNU-PR-Package: emacs Original-Received: via spool by 57325-submit@debbugs.gnu.org id=B57325.166186342411953 (code B ref 57325); Tue, 30 Aug 2022 12:44:02 +0000 Original-Received: (at 57325) by debbugs.gnu.org; 30 Aug 2022 12:43:44 +0000 Original-Received: from localhost ([127.0.0.1]:35063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oT0am-00036j-Cu for submit@debbugs.gnu.org; Tue, 30 Aug 2022 08:43:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oT0aj-00036W-H0 for 57325@debbugs.gnu.org; Tue, 30 Aug 2022 08:43:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36208) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT0ae-0004fx-9v; Tue, 30 Aug 2022 08:43:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=z/ahRUAH042m4r62dlOL9yWCh45N+h/Ct9REqZbKlCo=; b=RxByPrCSL9Tn uIQ8JtbQ1Q2jB9DtjYOlFvbYDtJQi3mAIdvSkVjAUsK2qFt6BGAfqnY+uSU6KhzpjgO/lNyLuq/Hk VVTjp17j5yXUgD5gWpfItxOepDJhMLTWWiZQgAgYx5WIyKVskfjeWtpkIAWXBxD/PE4EiajEYJ9z7 Mw3y8MKb4PzDlA8tJ0effy5FTb6DISQn3HUc+z1aEd1ZB5sW75ii2gguPjr1piWXltT20+Ip3o76z 22GOGPO48wqAVRDGEyg7iscpbfaFHO7YwzorJ/QWIchxriPea7qZpSMvceuQoyPWxcE75WvMXIg7+ XsSggmtzIcFmt5rLskNzmQ==; Original-Received: from [87.69.77.57] (port=2792 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT0ac-0005uz-8A; Tue, 30 Aug 2022 08:43:36 -0400 In-Reply-To: <87pmgiqftt.fsf@betli.tmit.bme.hu> (message from Felician Nemeth on Tue, 30 Aug 2022 10:46:22 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241125 Archived-At: > From: Felician Nemeth > Cc: 57325@debbugs.gnu.org > Date: Tue, 30 Aug 2022 10:46:22 +0200 > > > If the returned list includes file names with leading directories, > > find-file.el strips the leading directories and uses the basename to > > match against. > > I think that not how it works. Sorry, I misread the code. You are right. But then I think we should replace this code in ff-get-file-name: (setq file (concat dir "/" filename)) with (setq file (expand-file-name filename dir)) and then the code will work with absolute file names as well, even if the file is not already visited in a buffer. Right? > Playing with the implementation, I think that these functions shouldn't > return extensions. They should return file names. You are right. I updated the doc string to say that.