From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Allen Li Newsgroups: gmane.emacs.bugs Subject: bug#46884: [External] : bug#46884: [PATCH] 27.1; Cannot run find-dired with -maxdepth Date: Fri, 12 Mar 2021 16:42:18 -0800 Message-ID: <80blbn28b9.fsf@felesatra.moe> References: <83k0qo699n.fsf@gnu.org> <83ft1c62hk.fsf@gnu.org> <80ft1bed4g.fsf@felesatra.moe> <87r1kv8dnt.fsf@mail.linkov.net> <808s72e14s.fsf@felesatra.moe> <835z26ysa5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27595"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: Phil Sainty , "46884@debbugs.gnu.org" <46884@debbugs.gnu.org>, Juri Linkov To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 13 01:43:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKsNC-00074g-Lv for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Mar 2021 01:43:18 +0100 Original-Received: from localhost ([::1]:55600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKsNB-00019R-Ln for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Mar 2021 19:43:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKsMw-00019J-Un for bug-gnu-emacs@gnu.org; Fri, 12 Mar 2021 19:43:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47159) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lKsMv-0002Wy-P5 for bug-gnu-emacs@gnu.org; Fri, 12 Mar 2021 19:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lKsMv-0001Nh-M7 for bug-gnu-emacs@gnu.org; Fri, 12 Mar 2021 19:43:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Mar 2021 00:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46884 X-GNU-PR-Package: emacs Original-Received: via spool by 46884-submit@debbugs.gnu.org id=B46884.16155961485267 (code B ref 46884); Sat, 13 Mar 2021 00:43:01 +0000 Original-Received: (at 46884) by debbugs.gnu.org; 13 Mar 2021 00:42:28 +0000 Original-Received: from localhost ([127.0.0.1]:58705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKsMO-0001Mt-59 for submit@debbugs.gnu.org; Fri, 12 Mar 2021 19:42:28 -0500 Original-Received: from mail-pf1-f196.google.com ([209.85.210.196]:45077) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKsMM-0001Mg-3R for 46884@debbugs.gnu.org; Fri, 12 Mar 2021 19:42:27 -0500 Original-Received: by mail-pf1-f196.google.com with SMTP id j12so2953149pfj.12 for <46884@debbugs.gnu.org>; Fri, 12 Mar 2021 16:42:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=felesatra-moe.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=fNGZ4uGHy0gSHUv/Gp58HoKlv2l44ruRZZmtU8I/ho4=; b=ubo12mEG1UEcQaPPGewLxlLejx+BYm+4lyV6otPvg8FVrRz8V/8ILuQ8KJX78FzGHK 9ctAIMBq7jTovU1WK2W0wD5TKrAucyAex+OzFIaIhD+kxTdI8RU2dRmBNjGqPxvHre7f qahMgmuXR5a5IsaqUBWrBmdpb/1xEIibaM4vORSHGkyBwDEwHpvd6pW1GxJs0FcENIQx 3aNPEo922035j7gWayPg6OjBV7vu4pgK9Vsio/yS4PQ3zOrVgj2EhtfbtTqsoPVTxNIM +14qohkrSQJCepuWFpmMDGmrsoddJGi0GaAWxTyiOWdRe2Pk+1UkHqVbKnWGHlod3ww+ FUGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=fNGZ4uGHy0gSHUv/Gp58HoKlv2l44ruRZZmtU8I/ho4=; b=n4P17rHHdni4O7tGqG0KdJIFmUw7rxtKDhyD16kjfBC31p0PZu0Nn698vsTREk6bre LdFIWJkTRAH+bEGkC9qsiAA2wWqVciZZWKEN/kAThVg+kB0dMxivTurdmQMKgwXYDo77 9axRG7oUDlavco/DzH7EZpaTIvTN/nglWSZ1TB6uwAPyhCt/XSSJvIHGcMo/T7rgWDEX 2m2UqU2K02tp6Vy60YBv4hnyxoI15iUwxQ2bhKSYriepck6vidGB6sb9ouXEMWWZD7/Z CVOLINmaUgd0wLTyecYzavmD+6Tjh2aEV13Tl8xzfu2Xy6//0q1EHIYN5spGj72p2A7w DcTA== X-Gm-Message-State: AOAM532EAjkIIpvaj+58+bsWt5Wjr1ffBmBXrq3bKgvdfhJwusk/jNmr +d6HS6utrhp2Zo0ucw50wX8fNg== X-Google-Smtp-Source: ABdhPJy3+jlCBs74XBQKN/yx0X9PEhglBBZW42bDcXrkta7syVXN4DDTbhtR+7SDKxCD7tr7vHtKJA== X-Received: by 2002:a63:2165:: with SMTP id s37mr14143706pgm.145.1615596140199; Fri, 12 Mar 2021 16:42:20 -0800 (PST) Original-Received: from localhost ([2600:1700:7270:7d1f:fa59:71ff:fe00:10cc]) by smtp.gmail.com with ESMTPSA id t17sm6838453pgk.25.2021.03.12.16.42.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 16:42:19 -0800 (PST) In-Reply-To: (Drew Adams's message of "Fri, 12 Mar 2021 15:49:04 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202217 Archived-At: Drew Adams writes: >> Attached patch, does this approach look good? > > What did you find wrong or missing with the > code I cited? It accepts DEPTH-LIMITS and > EXCLUDED-PATHS as optional args. Personally, I find it weirdly specialized and incomplete. There are many global options beside -mindepth and -maxdepth; your version supports none of those options. There is also no need to support EXCLUDED-PATHS separately; that can already be accomplished with the current find-dired API. I prefer a more flexible, general API, which is the current rgrep approach proposed by Juri and Phil on another bug [1]. There's also another bug open which can be closed if we adopt the rgrep approach [2]. [1]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27456 [2]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=32668