From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face Date: Mon, 26 Sep 2022 17:32:32 +0300 Message-ID: <7685a637-aa8f-3746-a0ad-7d07cce003be@yandex.ru> References: <87bkr2mhj1.fsf@protesilaos.com> <87a66mdych.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15167"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Cc: Lars Ingebrigtsen , Stefan Kangas To: Protesilaos Stavrou , 58092@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 26 16:53:32 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ocpUC-0003jP-LH for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Sep 2022 16:53:32 +0200 Original-Received: from localhost ([::1]:51364 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ocpUB-0004rf-Jd for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Sep 2022 10:53:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50178) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocpAN-0006lU-IT for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 10:33:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52239) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ocpAM-0005XH-9c for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 10:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ocpAM-0001TI-0c for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 10:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Sep 2022 14:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58092-submit@debbugs.gnu.org id=B58092.16642027645632 (code B ref 58092); Mon, 26 Sep 2022 14:33:01 +0000 Original-Received: (at 58092) by debbugs.gnu.org; 26 Sep 2022 14:32:44 +0000 Original-Received: from localhost ([127.0.0.1]:51317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocpA4-0001Sm-8S for submit@debbugs.gnu.org; Mon, 26 Sep 2022 10:32:44 -0400 Original-Received: from mail-wr1-f49.google.com ([209.85.221.49]:33343) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocpA1-0001SY-6i for 58092@debbugs.gnu.org; Mon, 26 Sep 2022 10:32:42 -0400 Original-Received: by mail-wr1-f49.google.com with SMTP id s14so10618158wro.0 for <58092@debbugs.gnu.org>; Mon, 26 Sep 2022 07:32:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date; bh=u6mNiC78HtXir4V4Ey7GHxXevUe6BnaGpb4jFJ/PrIw=; b=nHa5awGOW5umHC+NbpC0xK2g+wdwP9V9iGuprR2NYYxd8NkqpMU+RQTI03HCtphCs5 S/UcITGMQ/0o/mbQDhcwqMbisPyzdOz90sQSiPp/7Jyh1jWycSXplx50w/mj1WGAUvvL T+6FJdupAi8xQX8xR1jvBalOxdZO1+92skXU6gvvl5rPdk6aTAQpYMjLyUC9F1xRN9fG JTteID2csqYkvcmpHX+U56HfQpex4+IG6qS5/xGdvMmhedH65+rjqmZdrcmibLC5F2Ly Q3poEDr475oU/XsV3tVRARnMgigBRJ1+A4NsfN6H/TkN4/Z1srnA4YkNmZo6zC8u4b3C pKCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date; bh=u6mNiC78HtXir4V4Ey7GHxXevUe6BnaGpb4jFJ/PrIw=; b=UnVspPhn6gJYciIS5TmnfpJuRQ7YSRZVK0KnZ7uiHpFrUGdkV7fg7QPbeuU9oWyA8a G5nHKaJVhFrJImL8cLeEdsKi0dzRCLtt0OvolTRNlwM5vp/k+Gd/h5kl/vlFptKXDNha 9QFt2qJvsD6IZn4KM2FfHfrqu40XCj5Iq0UOYWxc67kEQ8JZt3GW/aqWXyJtPUevF27q PQOg19cbmR42HeJ2EjNfashEtILF754+VX2ZR+j3gwxCNgymYI7QaE2Jr6SlsSbq7PKs Cu1tVWz0tBYP/Fc7nYZHa1gmXpT215VuReyLzLoWym206vZCd3LnsU7+W/7rHP6YJfr/ J+ww== X-Gm-Message-State: ACrzQf2NZo8l2zp2bnxpj7nu29EFbEWIuQdDvLyPHiu8DMh7UgnnzkXi t7vKxVIQGiqb5lmRotwfL4w= X-Google-Smtp-Source: AMsMyM5GSXhC+IZf1eGdE6ogYJLYRGfFDRHJ4lA6a2sggMi2MFl9pIZYa45gqMOmt1z30OoyydVEQA== X-Received: by 2002:a05:6000:1887:b0:22a:3c3d:75ea with SMTP id a7-20020a056000188700b0022a3c3d75eamr13036726wri.669.1664202755296; Mon, 26 Sep 2022 07:32:35 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id e11-20020adfef0b000000b0022ae0965a8asm14736803wro.24.2022.09.26.07.32.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Sep 2022 07:32:34 -0700 (PDT) Content-Language: en-US In-Reply-To: <87a66mdych.fsf@protesilaos.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243665 Archived-At: On 26.09.2022 17:06, Protesilaos Stavrou wrote: >> From: Dmitry Gutov >> Date: Mon, 26 Sep 2022 16:28:56 +0300 >> >> Hi! >> >> On 26.09.2022 15:44, Protesilaos Stavrou wrote: >>> Dear maintainers, >>> >>> The attached patch replaces some hardcoded face properties in log-edit >>> buffers with a named face. >>> >>> The named face allows users/themes to customise how this line is styled. >>> >>> What do you think? >> LGTM, except perhaps call it headers-separator? It's used to separate >> all the headers, not just summary. > Hello everyone, > > I made the changes as you suggested and pushed them as commit > a386833503. However, I forgot to update the commit message of the > patch: it still mentions the old name of the face > 'log-edit-summary-separator' instead of 'log-edit-headers-separator'. > > Sorry for this mistake! Can I revert or amend it? If it's just in the commit message, then a revert won't help. And I don't think we have any tools for amending the change log so far. In any case, NEWS is more important than the commit message. So it's probably fine.