unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Daniel Mendler <mail@daniel-mendler.de>
To: "Dmitry Gutov" <dmitry@gutov.dev>,
	"Rudolf Adamkovič" <salutis@me.com>,
	62776@debbugs.gnu.org
Subject: bug#62776: 30.0.50; 'project-find-file' ignoring 'file-name-history'
Date: Wed, 19 Apr 2023 19:07:15 +0200	[thread overview]
Message-ID: <61ab8e9c-0265-051f-c0e9-4e3094e12789@daniel-mendler.de> (raw)
In-Reply-To: <7717d45c-b88c-5956-1018-dd86d44cd25f@gutov.dev>

On 4/19/23 17:49, Dmitry Gutov wrote:
> On 19/04/2023 18:46, Daniel Mendler wrote:
>>> IIUC the issue is that is has (added) special handling for file name
>>> completion, and predicates that on the name of the history variable. It
>>> can/should be combined with an extra check which makes sure that the
>>> completion table uses '/' as field separators. Maybe using the
>>> `completion-boundaries` thingy. Or just straight calling
>>> `completion-boundaries` on the history elements to extract the first
>>> segment instead of hardcoding '/'.
>> Vertico already handles completion boundaries. This is how the base
>> string `vertico--base` is computed. But as already mentioned, this is
>> unfortunately not the only issue. The issue is also that
>> `project-find-file` removes the base directory. The entries in the
>> history hash would need the same treatment.
> 
> But they do: the dynamically bound value of file-name-history at the 
> moment when completing-read is called contain only the relative file 
> names (with base directory removed).
> 
> That was the recent change in project.el we are referring to.

Ok okay, thanks! I didn't understand that. This makes a lot of sense
since then the history only contains valid values. Then you are right
that it is actually quite easy to repair the completion boundary issue
in `vertico--history-hash`.

Daniel





  reply	other threads:[~2023-04-19 17:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-11 15:21 bug#62776: 30.0.50; 'project-find-file' ignoring 'file-name-history' Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-12  1:18 ` Dmitry Gutov
2023-04-18 21:38   ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-19  1:54     ` Dmitry Gutov
2023-04-19  5:54       ` Daniel Mendler
2023-04-19 10:47         ` Dmitry Gutov
2023-04-19 12:05           ` Daniel Mendler
2023-04-19 15:28             ` Dmitry Gutov
2023-04-19 15:46               ` Daniel Mendler
2023-04-19 15:49                 ` Dmitry Gutov
2023-04-19 17:07                   ` Daniel Mendler [this message]
2023-04-19 22:24                     ` Dmitry Gutov
     [not found] ` <handler.62776.D62776.168194305529292.notifdone@debbugs.gnu.org>
2023-04-24  9:20   ` bug#62776: closed (Re: bug#62776: 30.0.50; 'project-find-file' ignoring 'file-name-history') Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61ab8e9c-0265-051f-c0e9-4e3094e12789@daniel-mendler.de \
    --to=mail@daniel-mendler.de \
    --cc=62776@debbugs.gnu.org \
    --cc=dmitry@gutov.dev \
    --cc=salutis@me.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).