unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dmitry@gutov.dev>
To: "Daniel Mendler" <mail@daniel-mendler.de>,
	"Rudolf Adamkovič" <salutis@me.com>,
	62776@debbugs.gnu.org
Subject: bug#62776: 30.0.50; 'project-find-file' ignoring 'file-name-history'
Date: Wed, 19 Apr 2023 18:28:32 +0300	[thread overview]
Message-ID: <360f88a8-8dd9-5fd3-51ef-4b670aad2272@gutov.dev> (raw)
In-Reply-To: <fe05d551-12af-53cf-a372-2835caee4a14@daniel-mendler.de>

On 19/04/2023 15:05, Daniel Mendler wrote:
> All in all this makes `project-find-file` a special case which we could
> handle specially in `vertico--history-hash`, but I try really hard to
> avoid accumulating special cases in Vertico. Another alternative would
> be to control the sorting directly in `project-find-file` by setting the
> `display-sort-function` and `cycle-sort-function`, maybe via a
> configuration variable. It is not really obvious where sorting is
> handled best. For example in my Consult package, which offers "highly
> tuned" completion commands, the commands usually try to control many
> aspects of completion (including sorting), while for other simpler
> commands it is better to let the completion UI do more of the work.

 From my outside perspective, it seems appropriate to handle inside this 
function, if it's at all possible to do without mentioning the exact 
command name, etc.

IIUC the issue is that is has (added) special handling for file name 
completion, and predicates that on the name of the history variable. It 
can/should be combined with an extra check which makes sure that the 
completion table uses '/' as field separators. Maybe using the 
`completion-boundaries` thingy. Or just straight calling 
`completion-boundaries` on the history elements to extract the first 
segment instead of hardcoding '/'.





  reply	other threads:[~2023-04-19 15:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-11 15:21 bug#62776: 30.0.50; 'project-find-file' ignoring 'file-name-history' Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-12  1:18 ` Dmitry Gutov
2023-04-18 21:38   ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-19  1:54     ` Dmitry Gutov
2023-04-19  5:54       ` Daniel Mendler
2023-04-19 10:47         ` Dmitry Gutov
2023-04-19 12:05           ` Daniel Mendler
2023-04-19 15:28             ` Dmitry Gutov [this message]
2023-04-19 15:46               ` Daniel Mendler
2023-04-19 15:49                 ` Dmitry Gutov
2023-04-19 17:07                   ` Daniel Mendler
2023-04-19 22:24                     ` Dmitry Gutov
     [not found] ` <handler.62776.D62776.168194305529292.notifdone@debbugs.gnu.org>
2023-04-24  9:20   ` bug#62776: closed (Re: bug#62776: 30.0.50; 'project-find-file' ignoring 'file-name-history') Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=360f88a8-8dd9-5fd3-51ef-4b670aad2272@gutov.dev \
    --to=dmitry@gutov.dev \
    --cc=62776@debbugs.gnu.org \
    --cc=mail@daniel-mendler.de \
    --cc=salutis@me.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).