From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.bugs Subject: bug#62776: 30.0.50; 'project-find-file' ignoring 'file-name-history' Date: Wed, 19 Apr 2023 19:07:15 +0200 Message-ID: <61ab8e9c-0265-051f-c0e9-4e3094e12789@daniel-mendler.de> References: <97545727-7123-ca74-3d2e-4ac5c6d8f25a@gutov.dev> <1310e385-f151-2a96-d7b9-cd21c082adc3@gutov.dev> <360f88a8-8dd9-5fd3-51ef-4b670aad2272@gutov.dev> <7717d45c-b88c-5956-1018-dd86d44cd25f@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="461"; mail-complaints-to="usenet@ciao.gmane.io" To: Dmitry Gutov , Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= , 62776@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 19 19:08:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ppBI2-000AaP-Ii for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Apr 2023 19:08:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ppBHr-0005H9-CE; Wed, 19 Apr 2023 13:08:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppBHn-0005F5-Hp for bug-gnu-emacs@gnu.org; Wed, 19 Apr 2023 13:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ppBHn-0001Wu-9q for bug-gnu-emacs@gnu.org; Wed, 19 Apr 2023 13:08:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ppBHm-0002FQ-Iu for bug-gnu-emacs@gnu.org; Wed, 19 Apr 2023 13:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Apr 2023 17:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62776 X-GNU-PR-Package: emacs Original-Received: via spool by 62776-submit@debbugs.gnu.org id=B62776.16819240488597 (code B ref 62776); Wed, 19 Apr 2023 17:08:02 +0000 Original-Received: (at 62776) by debbugs.gnu.org; 19 Apr 2023 17:07:28 +0000 Original-Received: from localhost ([127.0.0.1]:35702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppBHD-0002Ea-PQ for submit@debbugs.gnu.org; Wed, 19 Apr 2023 13:07:28 -0400 Original-Received: from server.qxqx.de ([178.63.65.180]:43089 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppBHB-0002EL-CY for 62776@debbugs.gnu.org; Wed, 19 Apr 2023 13:07:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ULgJjaeqD2fxuV/gCJSpj47XPS4Yj9kD2lilNh9abI8=; b=xvPYWgG+rlZD/XwnXtsHBLb1Rq a7X/V0a1Pf1/msbhV0zFvOWt7T14JjThNWAa0B/CneFgpBe3T8F0Rf9ATeO1qKzn3P2IcFnYfh17P XFJL9lJyI58kvJ7uF0ibTtUJmatg/CLe++H53FM5p6Tso8BoUybBKTq11+fcMk4GAg54=; Content-Language: en-US In-Reply-To: <7717d45c-b88c-5956-1018-dd86d44cd25f@gutov.dev> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260283 Archived-At: On 4/19/23 17:49, Dmitry Gutov wrote: > On 19/04/2023 18:46, Daniel Mendler wrote: >>> IIUC the issue is that is has (added) special handling for file name >>> completion, and predicates that on the name of the history variable. It >>> can/should be combined with an extra check which makes sure that the >>> completion table uses '/' as field separators. Maybe using the >>> `completion-boundaries` thingy. Or just straight calling >>> `completion-boundaries` on the history elements to extract the first >>> segment instead of hardcoding '/'. >> Vertico already handles completion boundaries. This is how the base >> string `vertico--base` is computed. But as already mentioned, this is >> unfortunately not the only issue. The issue is also that >> `project-find-file` removes the base directory. The entries in the >> history hash would need the same treatment. > > But they do: the dynamically bound value of file-name-history at the > moment when completing-read is called contain only the relative file > names (with base directory removed). > > That was the recent change in project.el we are referring to. Ok okay, thanks! I didn't understand that. This makes a lot of sense since then the history only contains valid values. Then you are right that it is actually quite easy to repair the completion boundary issue in `vertico--history-hash`. Daniel