From: Dmitry Gutov <dmitry@gutov.dev>
To: "Daniel Mendler" <mail@daniel-mendler.de>,
"Rudolf Adamkovič" <salutis@me.com>,
62776-done@debbugs.gnu.org
Subject: bug#62776: 30.0.50; 'project-find-file' ignoring 'file-name-history'
Date: Thu, 20 Apr 2023 01:24:04 +0300 [thread overview]
Message-ID: <7723fbd0-cd06-fc92-a1d6-291113580d0c@gutov.dev> (raw)
In-Reply-To: <61ab8e9c-0265-051f-c0e9-4e3094e12789@daniel-mendler.de>
On 19/04/2023 20:07, Daniel Mendler wrote:
> On 4/19/23 17:49, Dmitry Gutov wrote:
>> On 19/04/2023 18:46, Daniel Mendler wrote:
>>>> IIUC the issue is that is has (added) special handling for file name
>>>> completion, and predicates that on the name of the history variable. It
>>>> can/should be combined with an extra check which makes sure that the
>>>> completion table uses '/' as field separators. Maybe using the
>>>> `completion-boundaries` thingy. Or just straight calling
>>>> `completion-boundaries` on the history elements to extract the first
>>>> segment instead of hardcoding '/'.
>>> Vertico already handles completion boundaries. This is how the base
>>> string `vertico--base` is computed. But as already mentioned, this is
>>> unfortunately not the only issue. The issue is also that
>>> `project-find-file` removes the base directory. The entries in the
>>> history hash would need the same treatment.
>> But they do: the dynamically bound value of file-name-history at the
>> moment when completing-read is called contain only the relative file
>> names (with base directory removed).
>>
>> That was the recent change in project.el we are referring to.
> Ok okay, thanks! I didn't understand that. This makes a lot of sense
> since then the history only contains valid values. Then you are right
> that it is actually quite easy to repair the completion boundary issue
> in `vertico--history-hash`.
Now fixed in
https://github.com/minad/vertico/commit/ee148c0cb72f8ea306bf6bab3ef83f928cf82005.
Thanks all! Closing.
next prev parent reply other threads:[~2023-04-19 22:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 15:21 bug#62776: 30.0.50; 'project-find-file' ignoring 'file-name-history' Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-12 1:18 ` Dmitry Gutov
2023-04-18 21:38 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-19 1:54 ` Dmitry Gutov
2023-04-19 5:54 ` Daniel Mendler
2023-04-19 10:47 ` Dmitry Gutov
2023-04-19 12:05 ` Daniel Mendler
2023-04-19 15:28 ` Dmitry Gutov
2023-04-19 15:46 ` Daniel Mendler
2023-04-19 15:49 ` Dmitry Gutov
2023-04-19 17:07 ` Daniel Mendler
2023-04-19 22:24 ` Dmitry Gutov [this message]
[not found] ` <handler.62776.D62776.168194305529292.notifdone@debbugs.gnu.org>
2023-04-24 9:20 ` bug#62776: closed (Re: bug#62776: 30.0.50; 'project-find-file' ignoring 'file-name-history') Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7723fbd0-cd06-fc92-a1d6-291113580d0c@gutov.dev \
--to=dmitry@gutov.dev \
--cc=62776-done@debbugs.gnu.org \
--cc=mail@daniel-mendler.de \
--cc=salutis@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).