From: Dmitry Gutov <dgutov@yandex.ru>
To: Pankaj Jangid <pankaj@codeisgreat.org>
Cc: Andrii Kolomoiets <andreyk.mad@gmail.com>, 44420-done@debbugs.gnu.org
Subject: bug#44420: 28.0.50; vc-register, under vc-dir buffer, says file already registered
Date: Sun, 8 Nov 2020 14:11:26 +0200 [thread overview]
Message-ID: <5d470a1e-d657-9f76-6ca3-eb6d3f7f3f6e@yandex.ru> (raw)
In-Reply-To: <m2zh3s1rmn.fsf@codeisgreat.org>
Version: 28.1
On 08.11.2020 04:58, Pankaj Jangid wrote:
> Dmitry Gutov <dgutov@yandex.ru> writes:
>
>> Does this work for y'all?
>>
>> diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
>> index 8def7da377..32664bcd25 100644
>> --- a/lisp/vc/vc.el
>> +++ b/lisp/vc/vc.el
>> @@ -1391,7 +1391,7 @@ vc-register
>> (unless fname
>> (setq fname buffer-file-name))
>> (when (vc-call-backend backend 'registered fname)
>> - (error "This file is already registered"))
>> + (error "This file is already registered: %s" fname))
>> ;; Watch out for new buffers of size 0: the corresponding file
>> ;; does not exist yet, even though buffer-modified-p is nil.
>> (when bname
>
> Yes. This is fine. User can then take action accordingly.
Very good, pushed to master.
Regarding the other concern: vc-register's docstring says:
Register into a version control system.
If VC-FILESET is given, register the files in that fileset.
Otherwise register the current file.
so the behavior seems correct.
Let us know if there's anything still amiss, though.
next prev parent reply other threads:[~2020-11-08 12:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 15:51 bug#44420: 28.0.50; vc-register, under vc-dir buffer, says file already registered Pankaj Jangid
2020-11-03 17:42 ` Andrii Kolomoiets
2020-11-03 18:11 ` Pankaj Jangid
2020-11-05 8:05 ` Andrii Kolomoiets
2020-11-05 10:32 ` Pankaj Jangid
2020-11-08 2:25 ` Dmitry Gutov
2020-11-08 2:58 ` Pankaj Jangid
2020-11-08 12:11 ` Dmitry Gutov [this message]
2020-11-08 12:21 ` Andrii Kolomoiets
2020-11-08 12:29 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d470a1e-d657-9f76-6ca3-eb6d3f7f3f6e@yandex.ru \
--to=dgutov@yandex.ru \
--cc=44420-done@debbugs.gnu.org \
--cc=andreyk.mad@gmail.com \
--cc=pankaj@codeisgreat.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).