From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#44420: 28.0.50; vc-register, under vc-dir buffer, says file already registered Date: Sun, 8 Nov 2020 14:11:26 +0200 Message-ID: <5d470a1e-d657-9f76-6ca3-eb6d3f7f3f6e@yandex.ru> References: <10f619e6-c82c-54dc-133c-4fe8306c8db3@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30445"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: Andrii Kolomoiets , 44420-done@debbugs.gnu.org To: Pankaj Jangid Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 08 13:12:22 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kbjYU-0007o8-EL for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Nov 2020 13:12:22 +0100 Original-Received: from localhost ([::1]:38474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kbjYT-0004kC-Gv for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Nov 2020 07:12:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kbjYA-0004j7-Ig for bug-gnu-emacs@gnu.org; Sun, 08 Nov 2020 07:12:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48352) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kbjYA-00025a-8g for bug-gnu-emacs@gnu.org; Sun, 08 Nov 2020 07:12:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kbjYA-0007j2-33 for bug-gnu-emacs@gnu.org; Sun, 08 Nov 2020 07:12:02 -0500 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Nov 2020 12:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 44420 X-GNU-PR-Package: emacs Mail-Followup-To: 44420@debbugs.gnu.org, dgutov@yandex.ru, pankaj@codeisgreat.org Original-Received: via spool by 44420-done@debbugs.gnu.org id=D44420.160483749629662 (code D ref 44420); Sun, 08 Nov 2020 12:12:01 +0000 Original-Received: (at 44420-done) by debbugs.gnu.org; 8 Nov 2020 12:11:36 +0000 Original-Received: from localhost ([127.0.0.1]:59898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbjXj-0007iM-Sx for submit@debbugs.gnu.org; Sun, 08 Nov 2020 07:11:36 -0500 Original-Received: from mail-ej1-f50.google.com ([209.85.218.50]:38154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbjXi-0007i7-7m for 44420-done@debbugs.gnu.org; Sun, 08 Nov 2020 07:11:34 -0500 Original-Received: by mail-ej1-f50.google.com with SMTP id za3so8299161ejb.5 for <44420-done@debbugs.gnu.org>; Sun, 08 Nov 2020 04:11:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=H0efeOMedr6If0EPFRHNg+f4A2J137LOK0dki1frzbs=; b=MUYh4NpxEZkllJH/LDVVSw54NP0ZifhjLPX70dEidZvGeBQRtrjdaq6qrimc7er5Ss L8QfYhowjYSQ3ZUEs2vGrxP9sMnc8CHhfHqXJqaZTsbQKX81x3tDITxF47NqWlzQZQ77 xI2BtpXvi+OrXShnJKPFRgFXNPg2eJvqXACVo6AfYP1JYBd3/yo6fH6iSxlLoW4tAZmG elbc0WxzOn59kD7ESfkiW2Hb6RfskuNjgTcZ3vV7VtAXRwB2fW2E4tsoF+l7hXbl/+BE 0ouBJPeTYzgfDoHqbnLId6VutZ5sZbv3b8nIHuIC0P0ekoGAJi8AuTK4CGbnOkRlhyqK PrnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=H0efeOMedr6If0EPFRHNg+f4A2J137LOK0dki1frzbs=; b=lLOCmY42UAJbdpdQpVw9SkfojRIGPynYeXKpgxONjaYr595NJ7h5+kKBCFMXU1ZzlH WFrprbhAafofm8ZABGxxjiJNS5FCwfu0dsxvnFNsSseNlT2EK4OGiEQ66vBQE0Gx4m7K Z8xbHzpz7nsFZmXXiGEIYUyl8XS1KnlKbIEFDAXOH+V9/BjbbhFEZ9FVvWqR8H/0kH7t Y6xGD053twcyyJD+mpKMXCVnUVB5yT/SYivftADeKKZyjz2VUqGIO60fH7xmxT01rCqX ssNV94Z7b6Cjfx4l3HCt15H5SROjIGqaox/sEJ7Rzxkw2iQ/gsFYQgBVQe37w3gHN6G6 Rh1A== X-Gm-Message-State: AOAM532oTpe7Vd61r512yKwZpJxBu5Fdpo0yIPNvgvm0kcqFcWmE2GEK pgc0nTIeXpLIPkT70Os79MQ= X-Google-Smtp-Source: ABdhPJxmQssPGRj7qrQxmSEd4TyHfXsBMiyMahtuFDv2Subx50ahSMLDfmBhfULrJ4SrtCMR+ZmEWQ== X-Received: by 2002:a17:906:ccc5:: with SMTP id ot5mr10849892ejb.248.1604837488451; Sun, 08 Nov 2020 04:11:28 -0800 (PST) Original-Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id b8sm5800666edv.20.2020.11.08.04.11.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Nov 2020 04:11:27 -0800 (PST) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192870 Archived-At: Version: 28.1 On 08.11.2020 04:58, Pankaj Jangid wrote: > Dmitry Gutov writes: > >> Does this work for y'all? >> >> diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el >> index 8def7da377..32664bcd25 100644 >> --- a/lisp/vc/vc.el >> +++ b/lisp/vc/vc.el >> @@ -1391,7 +1391,7 @@ vc-register >> (unless fname >> (setq fname buffer-file-name)) >> (when (vc-call-backend backend 'registered fname) >> - (error "This file is already registered")) >> + (error "This file is already registered: %s" fname)) >> ;; Watch out for new buffers of size 0: the corresponding file >> ;; does not exist yet, even though buffer-modified-p is nil. >> (when bname > > Yes. This is fine. User can then take action accordingly. Very good, pushed to master. Regarding the other concern: vc-register's docstring says: Register into a version control system. If VC-FILESET is given, register the files in that fileset. Otherwise register the current file. so the behavior seems correct. Let us know if there's anything still amiss, though.