From: Dmitry Gutov <dgutov@yandex.ru>
To: Pankaj Jangid <pankaj@codeisgreat.org>,
Andrii Kolomoiets <andreyk.mad@gmail.com>
Cc: 44420@debbugs.gnu.org
Subject: bug#44420: 28.0.50; vc-register, under vc-dir buffer, says file already registered
Date: Sun, 8 Nov 2020 04:25:37 +0200 [thread overview]
Message-ID: <10f619e6-c82c-54dc-133c-4fe8306c8db3@yandex.ru> (raw)
In-Reply-To: <m2r1p89jrp.fsf@codeisgreat.org>
On 05.11.2020 12:32, Pankaj Jangid wrote:
>>>> Including file name in the "File already registered" message may help to
>>>> understand whats going on though.
>>> This could be a long list. We can just say "Marked file(s) already
>>> registered".
>> Files in the list are checked one by one and error is returned for the
>> first registered file. IMO filename will fit well in the error message.
> Yes one filename will definitely fit.
Does this work for y'all?
diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
index 8def7da377..32664bcd25 100644
--- a/lisp/vc/vc.el
+++ b/lisp/vc/vc.el
@@ -1391,7 +1391,7 @@ vc-register
(unless fname
(setq fname buffer-file-name))
(when (vc-call-backend backend 'registered fname)
- (error "This file is already registered"))
+ (error "This file is already registered: %s" fname))
;; Watch out for new buffers of size 0: the corresponding file
;; does not exist yet, even though buffer-modified-p is nil.
(when bname
next prev parent reply other threads:[~2020-11-08 2:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 15:51 bug#44420: 28.0.50; vc-register, under vc-dir buffer, says file already registered Pankaj Jangid
2020-11-03 17:42 ` Andrii Kolomoiets
2020-11-03 18:11 ` Pankaj Jangid
2020-11-05 8:05 ` Andrii Kolomoiets
2020-11-05 10:32 ` Pankaj Jangid
2020-11-08 2:25 ` Dmitry Gutov [this message]
2020-11-08 2:58 ` Pankaj Jangid
2020-11-08 12:11 ` Dmitry Gutov
2020-11-08 12:21 ` Andrii Kolomoiets
2020-11-08 12:29 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10f619e6-c82c-54dc-133c-4fe8306c8db3@yandex.ru \
--to=dgutov@yandex.ru \
--cc=44420@debbugs.gnu.org \
--cc=andreyk.mad@gmail.com \
--cc=pankaj@codeisgreat.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).