From: Pankaj Jangid <pankaj@codeisgreat.org>
To: Andrii Kolomoiets <andreyk.mad@gmail.com>
Cc: 44420@debbugs.gnu.org
Subject: bug#44420: 28.0.50; vc-register, under vc-dir buffer, says file already registered
Date: Thu, 05 Nov 2020 16:02:10 +0530 [thread overview]
Message-ID: <m2r1p89jrp.fsf@codeisgreat.org> (raw)
In-Reply-To: <m2v9ekkz3q.fsf@gmail.com> (Andrii Kolomoiets's message of "Thu, 05 Nov 2020 10:05:29 +0200")
Andrii Kolomoiets <andreyk.mad@gmail.com> writes:
>> Got it. But the second clause `or the current directory if no files are
>> marked' is not accurate. Because in that case `i' (vc-register) works if
>> the point is on an untracked item.
>
> Indeed.
>
>> Wait... is `vc-deduce-fileset' relevant for `vc-register'? I don't
>> know.
>
> Yes. `vc-register` is calling `vc-deduce-fileset` right after `interactive`.
So, it's a bug.
>>> Including file name in the "File already registered" message may help to
>>> understand whats going on though.
>>
>> This could be a long list. We can just say "Marked file(s) already
>> registered".
>
> Files in the list are checked one by one and error is returned for the
> first registered file. IMO filename will fit well in the error message.
Yes one filename will definitely fit.
next prev parent reply other threads:[~2020-11-05 10:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 15:51 bug#44420: 28.0.50; vc-register, under vc-dir buffer, says file already registered Pankaj Jangid
2020-11-03 17:42 ` Andrii Kolomoiets
2020-11-03 18:11 ` Pankaj Jangid
2020-11-05 8:05 ` Andrii Kolomoiets
2020-11-05 10:32 ` Pankaj Jangid [this message]
2020-11-08 2:25 ` Dmitry Gutov
2020-11-08 2:58 ` Pankaj Jangid
2020-11-08 12:11 ` Dmitry Gutov
2020-11-08 12:21 ` Andrii Kolomoiets
2020-11-08 12:29 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2r1p89jrp.fsf@codeisgreat.org \
--to=pankaj@codeisgreat.org \
--cc=44420@debbugs.gnu.org \
--cc=andreyk.mad@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).